Problem/Motivation

Sometimes you want to vary markup by the feature flag

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3278318-6.patch3.59 KBlarowlan
#7 3278318-interdiff-6.txt820 byteslarowlan
#4 3278318-4.patch2.79 KBlarowlan
#4 3278318-interdiff-4.txt1.56 KBlarowlan
#2 3278318-pass.patch2.69 KBlarowlan
#2 3278318-fail.patch734 byteslarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new 3278318-fail.patch734 bytes
new 3278318-pass.patch2.69 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
+++ b/src/FeatureFlagContext.php
@@ -0,0 +1,58 @@
+    return (new CacheableMetadata())->addCacheTags(['config:feature_flag.flag.global_navigation']);

gah whoops, hard-coded here, fixing

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3278318-interdiff-4.txt1.56 KB
new 3278318-4.patch2.79 KB

The last submitted patch, 2: 3278318-pass.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 2: 3278318-fail.patch, failed testing. View results

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3278318-interdiff-6.txt820 bytes
new 3278318-6.patch3.59 KB

The last submitted patch, 4: 3278318-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan credited mstrelan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community

  • larowlan committed 4b1c68c on 2.x 
    Issue #3278318 by larowlan, mstrelan: Add a cache context for feature...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Cutting a 2.x release

  • larowlan committed 054282d on 2.x 
    Issue #3278318 by larowlan, mstrelan: Add a cache context for feature...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.