Problem/Motivation

We need to update the code, README.md and the libraires.yml to be compatible with the latest 1.10 version.

Proposed resolution

Update the code.

Remaining tasks

  1. Code
  2. Review
  3. Commit

Issue fork lightgallery-3277259

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

murilohp created an issue. See original summary.

murilohp’s picture

murilohp commented
Issue summary: View changes
Status: Active » Needs review

murilohp opened merge request !10

anagomes’s picture

anagomes commented
Status: Needs review » Needs work

Hi @murilohp, this documentation looks like a great improvement. I see you already documented the usage of the module, so maybe you could edit the introduction and add a link to the project's page, add the requirements and the maintainers sections, to make it follow the README standards, and then we could close #3275563: Improve README of the module as a duplicate. What do you think?

murilohp’s picture

murilohp commented

Thanks for the review @anagomes, I'll work on the improvement today, regading the #3275563: Improve README of the module, we can close as duplicate, I'll just transfer the credit for you here.

murilohp’s picture

murilohp commented
Status: Needs work » Reviewed & tested by the community
murilohp’s picture

murilohp commented
Issue summary: View changes

  • 8ef2366 committed on 8.x-1.x 
    Issue #3277259 by murilohp, anagomes: Update the code to be compatible...
murilohp’s picture

murilohp commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Commited to 8.x-1.x, thanks!

murilohp closed merge request !10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.