Problem/Motivation

Module doesn't have tests. Tests should be provided for it.

CommentFileSizeAuthor
#7 link_description-tests-3276492-7.patch19.56 KBsinn

Issue fork link_description-3276492

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3276492-tests Comparechanges, plain diff MR !1
  • 1.0.x Comparecompare
About issue forks

Comments

sinn created an issue. See original summary.

sinn opened merge request !1

kirkkala’s picture

kirkkala
He/him
Primary language Finnish
Location Helsinki
commented

Brilliant, thank you @sinn. I created the dev release, you should be able now to add/run tests from https://www.drupal.org/node/3185508/qa

sinn’s picture

sinn commented
Status: Active » Needs review

sinn closed merge request !1

sinn reopened merge request !1

sinn’s picture

sinn commented
StatusFileSize
new link_description-tests-3276492-7.patch19.56 KB

Let's try to test the patch.

joevagyok’s picture

joevagyok commented
Status: Needs review » Needs work

Looks good, just need some cleanup. I provided my code review above.

kirkkala’s picture

kirkkala
He/him
Primary language Finnish
Location Helsinki
commented

Thanks @sinn for working on this!

I just merged your bugfix https://www.drupal.org/project/link_description/issues/3276985 - would you feel like amending to tests the line-breaks and html markup in the description field and I'll create beta2 relese with these tests?

sinn’s picture

sinn commented
Status: Needs work » Needs review
joevagyok’s picture

joevagyok commented
Status: Needs review » Reviewed & tested by the community

Thanks for the changes, now looks good I approve.

  • kirkkala committed a7b2f68 on 1.0.x authored by sinn 
    Issue #3276492: Provide test coverage for the module.
kirkkala’s picture

kirkkala
He/him
Primary language Finnish
Location Helsinki
commented
Version: 1.0.0-beta1 » 1.0.0-beta2
Assigned: sinn » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.