Problem/Motivation
Currently and for the recommended 2.0.0-beta2 version, there is no
elements generated for vtt files for Remote Video entities. Additionally, there is no way to add such files to a Remote Video entity, as is the case for the Video entities.
Proposed resolution
Try to re-use the codes that are used during install and attach vtt file uploading fields as well as the respective formatters and the rendering logic.
Remaining tasks
Provide a patch
Issue fork ableplayer-3275879
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
stefanos.petrakisReady for review
Comment #4
themusician commentedThank you Stefanos. This is the same issue reported earlier, https://www.drupal.org/project/ableplayer/issues/3255707 so this might squash two issues at once. I'll try to test it tomorrow.
Max
Comment #6
themusician commentedThis looks good and works against the 2.x branch. In 3.x captions are handled as entity references so it will need a few changes to work in 3.x.
Comment #7
themusician commentedComment #8
stefanos.petrakisExcellent! Thanks for being so alert about this! I may be able to give a hand with the 3.x version if needed. It's kind of like [frontport]ing this issue.
Comment #9
themusician commentedAll the thanks to you. We really appreciate it and so glad the 2.x branch now has working caption files again for remote videos. Your code applied to the 3.x branch but since we retrieve the captions differently, they wouldn't appear. The other maintainer and I are working on making the tests run properly in Drupal 9/10 right now.
I like how you approached solving the problem with the helper. That is slick.