Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

CommentFileSizeAuthor
#2 3275530-2.patch20.78 KBdanflanagan8
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
CreditAttribution: danflanagan8 at Horizontal commented
Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
FileSize
3275530-2.patch20.78 KB

Some notes on this one, which looks like a bigger patch than it actually is, if you know what I mean.

1. LanguageBreadcrumbTest: Refactored to use AssertBreadcrumbTrait, which does not rely on Classy.
2. LanguageSwitchingTest: Too focused on classes. Added a todo with a followup to change to starterkit.
3. LanguageUILanguageNegotioationTest: Changed to selecting the branding block by ID instead of class.

Everything else is changes from pageText(Not)Contains assertions to statusMessage(Not)Contains assertions.

Status: Needs review » Needs work

The last submitted patch, 2: 3275530-2.patch, failed testing. View results

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
CreditAttribution: danflanagan8 at Horizontal commented
Status: Needs work » Needs review

Clearly a random fail. Back to NR!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.4.x-dev » 9.3.x-dev

Committed and pushed 446bc5dd42 to 10.0.x and f4a0295868 to 9.5.x and f9e7b7811c to 9.4.x. Thanks!

  • alexpott committed 446bc5d on 10.0.x 
    Issue #3275530 by danflanagan8: Language Tests should not rely on Classy

  • alexpott committed f4a0295 on 9.5.x 
    Issue #3275530 by danflanagan8: Language Tests should not rely on Classy...

  • alexpott committed f9e7b78 on 9.4.x 
    Issue #3275530 by danflanagan8: Language Tests should not rely on Classy...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

I this passes on 9.3.x will merge there too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Glad I didn't commit that to 9.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.