The UpdateSettingsForm class doesn't implement the create() method as per the documentation
https://api.drupal.org/api/drupal/core%21modules%21update%21src%21Update...
public static function create(ContainerInterface $container) {
$instance = parent::create($container);
$instance->emailValidator = $container
->get('email.validator');
return $instance;
}
The form class should have a __construct method and then provide all injected dependencies in the create method.
Issue fork drupal-3275216
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
akoepke commentedComment #4
larowlanI guess it's using this pattern https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl... but we don't need that in core, because we can't break our own code
Comment #5
larowlanAlso this is more a task than a bug
Comment #6
joachim commentedLGTM.
Comment #9
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!