Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
File core/themes/olivero/css/base/variable.css is empty (contains only comments) after build command.
Steps to reproduce
cd core
yarn install
yarn build:css
Issue fork drupal-3274598
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3274598-the-compiled-variable.css changes, plain diff MR !2774
Comments
Comment #2
cilefen CreditAttribution: cilefen commentedComment #4
uditrawat CreditAttribution: uditrawat as a volunteer and commentedComment #6
andy-blumThe file only containing comments is due to the fact that variables are compiled at build time and we can't ship true CSS vars to IE11. The bigger issue is that we probably shouldn't be including this file in the library, but even that's not a big issue as core's aggregation and minification will strip out all comments and empty rulesets. Fix incoming.
Comment #8
andy-blumComment #9
longwaveThis is a nice easy solution. We still build the useless file at build time but we don't need to ship it to the browser.
To be clear to committers: this issue only affects 9.4.x and 9.5.x. 10.0.x onwards *do* need to include this file in Olivero as we use CSS variables there.
Comment #11
lauriiiCommitted b6bbe7c and pushed to 9.5.x. Thanks!
Comment #13
longwave