Problem/Motivation

Menu items in OpenAPI Redoc interface have no label with Gin theme enabled.

This issue happens with "Horizontal, Modern Toolbar" and "Legacy, Classic Drupal Toolbar" but NOT "Sidebar, Vertical Toolbar (Default)".

As .menu-item-title selector is used unscoped in horizontal_toolbar.css it causes elements with the same class within the page body to be set to display: none !important. Redoc happens to use the same class names.

Steps to reproduce

* Set Gin as admin theme
* Set Toolbar to "Horizontal, Modern Toolbar"
* Install OpenAPI Redoc modules:
composer require 'drupal/openapi_ui_redoc:^1.0@RC' 'drupal/openapi_jsonapi:^3.0' 'drupal/openapi:^2.0'
* Enable OpenAPI Redoc modules (and core JSON:API) :
drush en openapi_ui_redoc openapi_jsonapi openapi jsonapi
* Visit /admin/config/services/openapi/redoc/jsonapi
Items in Redoc left menu have no label displaying

Screenshot of menu with missing labels

Proposed resolution

Add scope to .menu-item-title selector in horizontal_toolbar.css. E.g use .toolbar .menu-item-title instead.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3274506-with-updated-selector.png377.15 KBkmbremner
#3 3274506-with-curent-selector.png306.82 KBkmbremner

Issue fork gin-3274506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kmbremner created an issue. See original summary.

kmbremner’s picture

kmbremner
he/him
Primary language English
Location Wetherby, UK
commented
Issue summary: View changes

Added steps to reproduce (and screenshots)

kmbremner’s picture

kmbremner
he/him
Primary language English
Location Wetherby, UK
commented
Issue summary: View changes
StatusFileSize
new 3274506-with-curent-selector.png306.82 KB
new 3274506-with-updated-selector.png377.15 KB
kmbremner’s picture

kmbremner
he/him
Primary language English
Location Wetherby, UK
commented
Issue summary: View changes

tidied up shell commands in issue description

kmbremner opened merge request !128

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed 3d30ccb on 8.x-3.x authored by kmbremner 
    Issue #3274506: Add scope to `.menu-item-title` selector so rule only...
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Fixed

Thanks @kmbremner!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.