Problem/Motivation
The deprecation message for taxonomy_term_load_multiple_by_name() is incorrect, it should use taxonomy_term and not taxonomy_vocabulary.
It currently says:
@trigger_error('taxonomy_term_load_multiple_by_name() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal::entityTypeManager()->getStorage("taxonomy_vocabulary")->loadByProperties(["name" => $name, "vid" => $vid]) instead, to get a list of taxonomy term entities having the same name and keyed by their term ID. See https://www.drupal.org/node/3039041', E_USER_DEPRECATED);
But that would mean it will load vocabularies and not terms.
The CR got it right though, see https://www.drupal.org/node/3039041
Steps to reproduce
Read the message and the code following it, they don't line up.
Proposed resolution
Use the correct entity type.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3272722-2.patch | 2.6 KB | lendude |
Comments
Comment #2
lendudeShould be something like this
Comment #3
lendudeComment #4
larowlanGreat pickup
Comment #5
dwwAgreed, good find! This would be really confusing for developers. ;) +1 to RTBC, and tagging to be smashed.
Comment #7
lendudeUnrelated fail
Comment #9
dwwMore random fail:
Comment #11
catchCommitted 057214c and pushed to 9.4.x. Thanks!