Problem/Motivation

The deprecation message for taxonomy_term_load_multiple_by_name() is incorrect, it should use taxonomy_term and not taxonomy_vocabulary.

It currently says:

  @trigger_error('taxonomy_term_load_multiple_by_name() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal::entityTypeManager()->getStorage("taxonomy_vocabulary")->loadByProperties(["name" => $name, "vid" => $vid]) instead, to get a list of taxonomy term entities having the same name and keyed by their term ID. See https://www.drupal.org/node/3039041', E_USER_DEPRECATED);

But that would mean it will load vocabularies and not terms.

The CR got it right though, see https://www.drupal.org/node/3039041

Steps to reproduce

Read the message and the code following it, they don't line up.

Proposed resolution

Use the correct entity type.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3272722-2.patch2.6 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

Status: Active » Needs review
StatusFileSize
new2.6 KB

Should be something like this

lendude’s picture

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Great pickup

dww’s picture

Issue tags: +Bug Smash Initiative

Agreed, good find! This would be really confusing for developers. ;) +1 to RTBC, and tagging to be smashed.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3272722-2.patch, failed testing. View results

lendude’s picture

Status: Needs work » Reviewed & tested by the community

Unrelated fail

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3272722-2.patch, failed testing. View results

dww’s picture

Status: Needs work » Reviewed & tested by the community

More random fail:

There was 1 error:

1) Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest::testDrupalImageDialog
Behat\Mink\Exception\ElementNotFoundException: Element matching css "#cke_edit-body-0-value .cke_button__drupalimage" not found.

  • catch committed 057214c on 9.4.x
    Issue #3272722 by Lendude: The deprecation message for...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 057214c and pushed to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.