Make module compatible with Drupal 10

We may want to use the Drupal event subscriber proxy instead of the direct symfony one. I'm also worried about page manager support here, since it wouldn't be compatible with this version of ctools.

If we can keep it D8.9 compatible lets try for that first.

Reviewed a bit. I don't think 8.9 compatibility is possible nor necessary, it's impossible to test against D8 now. Agree with the event class use. I think then it would still work with page manager?

Tests fail on D10 due to the the required setUp() change and I guess also $modules definition if that wasn't already changed elsewhere.

Also, looks this overlapped with #3259348: Remove Drupal 8 compatibility in info.yml, which (IMHO unnecessarily) made the D8 change already, so that's off the table already anyway and this will need a rebase.

Ah, I see why I was confused, there is a new 4.x branch that contains those changes. I guess 8.x-3.x should not be changed at all then.

Don't forget to update the issue when working on a MR as it does not send out notifications.

That said, this is still against 8.x-3.x, and I assume needs to be redone against 4.x instead, which is already defined as D10 compatible.

Looking into this as it's blocking pathauto.

Switching to a patch because I can't force push that branch or change the branch target. There were a number of tricky bits in there that static analysis does not cover, I'll post a self-review to explain them.

I also included #3191286: Signature of EventDispatcherInterface::dispatch() has changed, with this, all tests pass against D10 without deprecations (various things have not actually been removed yet) for me locally.

Patch against wrong branch, ignore that.

1. +++ b/composer.json
   @@ -42,6 +42,6 @@
      "require": {
   -    "drupal/core": "^9 || ^10"
   +    "drupal/core": "^9.1 || ^10"
      }
    }
   

   increased the min version to 9.1, many things require that, not 9.0 (context changes, event changes, ..)

2. +++ b/ctools.services.yml
   @@ -31,8 +31,3 @@ services:
   -  ctools.serializable.tempstore.factory:
   -    class: Drupal\ctools\SerializableTempstoreFactory
   -    arguments: ['@keyvalue.expirable', '@lock', '@request_stack', '%tempstore.expire%', '@current_user']
   -    tags:
   -      - { name: backend_overridable }
   

   The serializable tempstore factory + service + SerializableTempstore did exactly one thing. Add DependencySerializationTrait to SharedTempStore. That has been in core since Drupal 8.7.

   The reason I removed it is because the unit test makes the Request object implement Serializable, which is deprecated in PHP 8.1.

   The factory is also broken on D9.3+ I think because it uses old session handling which no longer works.

   I could find no usage of that service in the module, and as a major new version, I think it's fine to remove that?

   We could also just remove the test, but I don't really see any points in keeping this stuff.

3. +++ b/modules/ctools_views/tests/src/Functional/CToolsViewsBasicViewBlockTest.php
   @@ -45,8 +45,8 @@ class CToolsViewsBasicViewBlockTest extends UITestBase {
       */
   -  protected function setUp($import_test_views = TRUE): void {
   -    parent::setUp($import_test_views);
   +  protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void {
   +    parent::setUp($import_test_views, $modules);
   

   this is quite weird, but it seems to be backwards compatible. D10 without it is a fatal error.

4. +++ b/src/Routing/Enhancer/WizardEnhancer.php
   @@ -3,7 +3,7 @@
    
    use Drupal\Core\Routing\EnhancerInterface;
   -use Symfony\Cmf\Component\Routing\RouteObjectInterface;
   +use Drupal\Core\Routing\RouteObjectInterface;
   

   Symfony\Cmf is removed in D10. This is the specific change I need for pathauto.

If you do commit this, don't forget to grant issue credits to people who worked on the other issue.

With this, we'll up the version to 9.2 (from 9.1), and backport some of the 3.x changes to 4.x. Once we get this pushed into 4.x, 3.x will become maintanence patches only, with defaults going into 4.x

Basically 8.x-3.x is for Drupal 8 and early versions of Drupal 9, and 4.x is for D9 (9.2+) and D10.

Fixed! Committed to 4.x

Tagging so easier to find. Thanks everyone!