Problem/Motivation
Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.
Proposed resolution
Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.
This is (likely) a relatively small issue. Only three test classes use Classy.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3272336-3.patch | 3.2 KB | danflanagan8 |
Comments
Comment #2
danflanagan8Comment #3
danflanagan8Simple patch attached.
It may be of interest to note that there is a Function JS test featuring the following lines.
This looked like a candidate for refactoring with the new
JsWebAssert::statusMessageExistsAfterWait, but that method cannot count the number of message, which is a key aspect of this assertion.The reason this assertion works even though that test uses stark is that this message is put on the page by
file.js, not the theme. It's an ajax thing.Comment #4
danflanagan8Comment #5
larowlanLooks good to me
Comment #7
larowlanComment #9
danflanagan8Looks like a random fail in a quickedit test. Resetting status.
Comment #10
alexpottCommitted and pushed 0a03e7b151 to 10.0.x and b74c35f541 to 9.5.x and f2bb791372 to 9.4.x. Thanks!
Gonna try running against 9.3.x to see if we can backport to keep tests aligned.
Comment #14
alexpottBackported to 9.3.x