Problem/Motivation

Running php code sniffer shows errors and warnings.

Steps to reproduce

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md .

Proposed resolution

Use phpcbf and manual effort to fix.

CommentFileSizeAuthor
#3 3269703-3.patch5.05 KBtmaiochi

Comments

PapaGrande created an issue. See original summary.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll work on this!

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Active » Needs review
StatusFileSize
new 3269703-3.patch5.05 KB

I fixed all messages from PHPCS.
Kindly review it.

Guilherme Rabelo’s picture

Guilherme Rabelo commented
Assigned: Unassigned » Guilherme Rabelo

I will review the patch.

Guilherme Rabelo’s picture

Guilherme Rabelo commented
Assigned: Guilherme Rabelo » Unassigned
Status: Needs review » Reviewed & tested by the community

Running the command below when applying patch #3, i didn't find any error messages.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,md,yml,js,txt .

Moving to RTBC!

  • PapaGrande committed 658fd71 on 2.0.x authored by tmaiochi 
    Issue #3269703 by tmaiochi, Guilherme Rabelo: Fix Code Sniffer Errors...
papagrande’s picture

papagrande
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

@tmaiochi, @guilherme-rabelo, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.