POSTPONED ON #2873160: Implement core management of 3rd-party FE libraries and use composers "suggest":
https://getcomposer.org/doc/04-schema.md#suggest until that's fixed.
Until this is not implemented in core, we will use "hook_requirements" to let the user know if there are "npm-asset" composer libraries missing.
Problem/Motivation
This part of the composer.json is problematic:
https://git.drupalcode.org/project/drowl_media/-/blob/3.x/composer.json:
"require": {
"npm-asset/drowl-admin-iconset": "^1.0"
}
as npm-asset is unknown to composer. This makes testing on drupal.org impossible:
https://www.drupal.org/pift-ci-job/2339058:
Updating dependencies
Your requirements could not be resolved to an installable set of packages.Problem 1
- drupal/drowl_media dev-3.x requires npm-asset/drowl-admin-iconset ^1.0 -> could not be found in any version, there may be a typo in the package name.
- drupal/drowl_media 3.x-dev is an alias of drupal/drowl_media dev-3.x and thus requires it to be installed too.
- Root composer.json requires drupal/drowl_media 3.x-dev#eaaf2633bc86491703155244c1d2fe549448a7ff -> satisfiable by drupal/drowl_media[3.x-dev (alias of dev-3.x)].Potential causes:
- A typo in the package name
- The package is not available in a stable-enough version according to your minimum-stability setting
see for more details.
- It's a private package and you forgot to add a custom repository to find itRead for further common problems.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
Related:
https://www.drupal.org/docs/develop/using-composer/using-composer-to-ins...
https://github.com/drupal-composer/drupal-project/issues/278
Issue fork drowl_media-3269497
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
anybodyLet's postpone this on #2873160: Implement core management of 3rd-party FE libraries and use composers "suggest":
https://getcomposer.org/doc/04-schema.md#suggest
Hopefully no one forgets the npm-asset until this can be solved cleanly.
Comment #4
anybodyFYI: Test currently failing (https://www.drupal.org/pift-ci-job/2339192) due to #3268564: Remove "core" key in views_test_linkarea.info.yml in views_linkarea dependent module.
Comment #5
anybodyPostponed on #2873160: Implement core management of 3rd-party FE libraries
Comment #6
anybodyComment #7
grevil commentedComment #9
grevil commentedFixed, through hook_requirements(). :)
Comment #10
grevil commentedComment #11
anybodyFailing tests now. ;)
Comment #12
grevil commentedHopefully it is fixed now... The problem is, that the drowl_media module has a lot of module dependencies and as we all know, dependencies for Module testing is usually a lot of trouble!
Comment #13
grevil commentedAlright, finally green tests!
Comment #15
anybodyOnce again: Very well done! :P
Comment #16
anybodyNow in 3.0.29!