Problem/Motivation

Config inspector returns an error about missing config schema.

Steps to reproduce

Review and validity configurations with drush:
$ drush config:inspect --detail --only-error
This message appears:

prlp.settings:password_required
variable type is boolean but applied schema class is Drupal\Core\TypedData\Plugin\DataType\IntegerData

CommentFileSizeAuthor
#2 fix_prlp_settings_password_required_variable_type-3268419.patch425 bytesv.dovhaliuk

Issue fork prlp-3268419

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

v.dovhaliuk created an issue. See original summary.

v.dovhaliuk’s picture

v.dovhaliuk commented
StatusFileSize
new fix_prlp_settings_password_required_variable_type-3268419.patch425 bytes

Provided patch.

fromme’s picture

fromme commented
Status: Needs work » Reviewed & tested by the community

Reviewed patch #2. Patch applied and error is resolved.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: fix_prlp_settings_password_required_variable_type-3268419.patch, failed testing. View results

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti opened merge request !11

bharath-kondeti’s picture

bharath-kondeti commented
Status: Needs work » Needs review

Raised an MR with updated changes. Please review

fromme’s picture

fromme commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR "Issue#3268419: Resolve test cases that failed and move the code to MR".
The error is resolved.

ccrawford91 made their first commit to this issue’s fork.

  • bharath-kondeti authored 58dcc249 on 8.x-1.x 
    Issue#3268419: Resolve test cases that failed and move the code to MR.

elc made their first commit to this issue’s fork.

elc opened merge request !22

elc’s picture

elc commented
Version: 8.x-1.7 » 2.0.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

This patch has not been merged into 2.0.x.

klemendev’s picture

klemendev commented

Does lack of this patch in 2.0.x make this module not usable in this release branch, or it still works and is this just a warning?

elc’s picture

elc commented

The module will still continue to function, however it will continue to swap between an integer value interpreted as a boolean value, and a true boolean value for this config item.

It's a boolean in the form, should be a boolean because it's a checkbox and true/false, and currently preventing the full validation of the module configuration against the schema.

The point of having the config and schema matched up is to eventually turn on config schema enforcement and validation so that config (simple and entity) and entities can be validated at the entity level instead of a form, allowing for API updates to entities without bypassing all of the validation.

elc’s picture

elc commented
Status: Patch (to be ported) » Needs review

MR22 is pending review to be ported.

elc’s picture

elc commented
Status: Needs review » Reviewed & tested by the community

Marking as RTBC as this is the same change as 8.x-1.x just ported over.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Confirming RTBC for the fix in MR!22

ccrawford91’s picture

ccrawford91 commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.