Problem/Motivation

Querystrings are stripped from internal links due to normalizeHref returning the entity: style href if the original href has an entity context.

Steps to reproduce

  • Create some content with alias foo
  • Create another piece of content with a link in a wysiwyg field linking to /foo?language=fr
  • Save the content and notice the Linky created will be linking directly to the content and the ?language=fr querystring is lost.

Proposed resolution

Append the querystring part of the url to the returned href.

CommentFileSizeAuthor
#8 3266493-querystring-are-stripped.patch2.22 KBmcaddz

Issue fork linkyreplacer-3266493

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mcaddy created an issue. See original summary.

mcaddz’s picture

mcaddz commented
Title: Querystring are stripped from internal links » Querystrings are stripped from internal links
mcaddz’s picture

mcaddz commented
Title: Querystrings are stripped from internal links » Querystrings are stripped from links to content

mcaddy opened merge request !4

mcaddz’s picture

mcaddz commented
Status: Active » Needs review

mcaddy opened merge request !5

mcaddy closed merge request !5

mcaddz’s picture

mcaddz commented
StatusFileSize
new 3266493-querystring-are-stripped.patch2.22 KB

Uploading patch

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

The patch looks good to me.

  • dpi committed bb86486 on 2.x authored by mcaddy 
    Issue #3266493 by mcaddy: Fixed query from being stripped from entity...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Reviewed & tested by the community » Fixed

Merged.

Thanks.

This can be found in 2.2.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.