Problem/Motivation

Steps to reproduce

Run phpcs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 interdiff_1-3.txt21.36 KBtmaiochi
#3 3266323-3.patch29.85 KBtmaiochi
computed_field-phpcs-fixes.patch7.49 KBbendale

Comments

bendale created an issue. See original summary.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll review this!

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Active » Needs review
StatusFileSize
new 3266323-3.patch29.85 KB
new interdiff_1-3.txt21.36 KB

I saw in my review that it still had some messages from phpcs. I fixed almost all of them except these:

modules/contrib/computed_field/src/Plugin/Field/FieldWidget/ComputedWidgetBase.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 18 | ERROR   | Class property $default_value should use lowerCamel naming without underscores
 23 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------------------------------------------

because I didn't find all the usage of $default_value and I didn't know if the method was overriding so I kept them as they were.
Kindly review it.

Status: Needs review » Needs work

The last submitted patch, 3: 3266323-3.patch, failed testing. View results

bendale’s picture

bendale commented

Thank you @tmaiochi for the patch. I tested your patch and did not see any issues. It is working fine. I agree with you about keeping the remaining error and warning as it is.

lucienchalom’s picture

lucienchalom commented
Status: Needs work » Reviewed & tested by the community

I reiterate what @bendale said, there is only the reported errors.
So i am moving to RTBC.

  • 7f435124 committed on 3.x 
    Issue #3266323 by tmaiochi: Added PHPCS fixes.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.