Problem/Motivation

In UserViewsData there is a useless line of help text that could be removed.

Steps to reproduce

View UserViewsData.php
See 2 lines of help text

Proposed resolution

Removed useless line of help text.

Remaining tasks

Review
Commit

User interface changes

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Original post

core/modules/user/src/UserViewsData.php:85 ambiguous text
title or help?

CommentFileSizeAuthor
#5 interdiff_2-5.txt832 bytesravi.shankar
#5 3265724-5.patch831 bytesravi.shankar
#4 Screenshot 2022-05-15 at 21.18.57.png67.62 KBalexpott
#4 Screenshot 2022-05-15 at 21.19.49.png58.48 KBalexpott
#2 3265724.patch940 bytesnevergone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nevergone created an issue. See original summary.

nevergone’s picture

nevergone CreditAttribution: nevergone as a volunteer commented
Status: Active » Needs review
FileSize
3265724.patch940 bytes
Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak at Gizra commented
Status: Needs review » Reviewed & tested by the community

LGTM

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
FileSize
Screenshot 2022-05-15 at 21.19.49.png58.48 KB
Screenshot 2022-05-15 at 21.18.57.png67.62 KB 
+++ b/core/modules/user/src/UserViewsData.php
@@ -82,7 +82,7 @@ public function getViewsData() {
-    $data['users_field_data']['langcode']['help'] = $this->t('Original language of the user information');
+    $data['users_field_data']['langcode']['title'] = $this->t('Original language of the user information');

I think that we should remove $data['users_field_data']['langcode']['help'] = $this->t('Original language of the user information'); the current title is better.

Before

Title before

After

Title after

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3265724-5.patch831 bytes
interdiff_2-5.txt832 bytes

Made changes as per comment #4.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

Seems like an easy fix but would like an issue summary next time please.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Reviewed & tested by the community » Needs work

Sorry to push back on a simple change but this needs a title change. The title is part of the commit message and should reflect the change. The title here has nothing to do with the actual change, which is now removing a line of useless code. Will someone update the title?

And yes, I agree to an Issue Summary, even on a small issue the proposed resolution should be clear to reviewers and committers.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Title: UserViewsData.php: ambiguous text » Remove unused help text in UserViewsData
Issue summary: View changes
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Issue title and patch look good to me now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 254b587f31 to 10.1.x and ce69564e16 to 10.0.x and b12569bc9f to 9.5.x and 2db48c5175 to 9.4.x. Thanks!

  • alexpott committed 254b587 on 10.1.x 
    Issue #3265724 by ravi.shankar, nevergone, alexpott, quietone: Remove...

  • alexpott committed ce69564 on 10.0.x 
    Issue #3265724 by ravi.shankar, nevergone, alexpott, quietone: Remove...

  • alexpott committed b12569b on 9.5.x 
    Issue #3265724 by ravi.shankar, nevergone, alexpott, quietone: Remove...

  • alexpott committed 2db48c5 on 9.4.x 
    Issue #3265724 by ravi.shankar, nevergone, alexpott, quietone: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.