Problem/Motivation

Follow-up from #3257127: Trigger a deprecation message when a deprecated module or theme is enabled. Help topics and REST both need to filter out deprecated modules when discovering things to test.

Steps to reproduce

Proposed resolution

Filter them out. Easy for REST, might need a bit more work for help_topics.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3264435-9.patch2.32 KBcatch
#9 3264435-interdiff-6-9.txt1.87 KBcatch
#5 3264435-4.patch1.75 KBcatch
#5 3264435-4-combined.patch2.2 KBcatch
#3 3264435-combined.patch2.84 KBcatch
#2 3264435.patch2.39 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3264435.patch2.39 KB
catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new 3264435-combined.patch2.84 KB

With the quickedit deprecation.

Status: Needs review » Needs work

The last submitted patch, 3: 3264435-combined.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3264435-4-combined.patch2.2 KB
new 3264435-4.patch1.75 KB

Better approach to help_topics.

The last submitted patch, 5: 3264435-4-combined.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented

The 16 fails in #5 are expected, those tests need to be marked legacy in #3227033: Remove Quick Edit from core, the the reduction from 18 test fails on #3227033-99: Remove Quick Edit from core shows this is working for rest and help_topics.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work

Nitpickers gonna nit pick... :)

1. 

diff --git a/core/modules/help_topics/tests/src/Functional/HelpTopicsSyntaxTest.php b/core/modules/help_topics/tests/src/Functional/HelpTopicsSyntaxTest.php
@@ -282,7 +282,7 @@ protected function listDirectories($type) {
       // Skip obsolete modules.

Can this become 

       // Skip obsolete and deprecated modules.

2. 

diff --git a/core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php b/core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php
index 90ea2ef833..c0750da06a 100644
@@ -47,6 +47,7 @@ protected function setUp(): void {

Can the comment above this change become:

      // Filter out contrib, hidden, testing, deprecated and experimental
      // modules. We also don't need to enable modules that are already enabled.
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3264435-interdiff-6-9.txt1.87 KB
new 3264435-9.patch2.32 KB

Should resolve #8.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

I'm happy if TestBot also is being green after the testrun (and we all now it's not easy being...)

  • ac05f3d committed on 10.0.x 
    Issue #3264435 by catch, Spokje: Help topics and rest don't filter out...

  • 18c089b committed on 9.4.x 
    Issue #3264435 by catch, Spokje: Help topics and rest don't filter out...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.