Problem/Motivation

#3257407: Use "content" region in BlockCreationTrait::placeBlock() instead of "sidebar_first" included some region overrides in tests to work-around #3257504: Empty toolbar tray displays a stray orientation toggle. Both of those have been committed now, but they were committed very close to each other so the workarounds were not removed in time. Now they are obsolete, though. Most of them were removed again in #3259928: Change various tests that test with "all themes" to also include Olivero but one remains.

Steps to reproduce

-

Proposed resolution

Remove the - now unnecessary - region override.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

Issue fork drupal-3262320

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler opened merge request !1772

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Reviewed & tested by the community

Fix looked good. With better coordination I could have asked for the second one committed to cover this. Oh well :D

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Reviewed & tested by the community » Active
Related issues: +#3261254: Failing test Drupal\Tests\quickedit\FunctionalJavascript\SettingsTrayIntegrationTest::testQuickEditLinks, +#3227033: Remove Quick Edit from core, +#3259928: Change various tests that test with "all themes" to also include Olivero
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review

Status change was accidental, but I guess another look couldn't hurt.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Issue summary: View changes

#3259928: Change various tests that test with "all themes" to also include Olivero landed so this just leaves one change now.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Title: Remove obsolete region overrides in tests » Remove obsolete region override in ContextualLinksTest
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Super straightforward. Thanks!

  • catch committed c055bd2 on 10.0.x 
    Issue #3262320 by tstoeckler: Remove obsolete region override in...

  • catch committed 261d23d on 9.4.x 
    Issue #3262320 by tstoeckler: Remove obsolete region override in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.