Problem/Motivation

Using the default template for fields, when selecting the option "Visually hidden" for a field label, the label is shown correctly instead of being hidden.

Steps to reproduce

Proposed resolution

Add class visually-hidden when field label is set like that

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3260596-field-label-hidden-2.patch920 bytesdimitriskr

Issue fork radix-3260596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dimitriskr created an issue. See original summary.

dimitriskr’s picture

dimitriskr commented
StatusFileSize
new 3260596-field-label-hidden-2.patch920 bytes
bserem’s picture

bserem commented

Does the css class exist in Radix? So, applying this will fix things?
Or does it need to be added too in this issue?

Also, mark the issue status as "needs review".

dimitriskr opened merge request !29

dimitriskr’s picture

dimitriskr commented
Status: Active » Needs review

I hid the patch in favor of the MR.

@bserem,
The class exists and applying this patch works as it should be

bserem’s picture

bserem commented
Status: Needs review » Active

Nice. The indentation seems wrong on lines 10->12 and 30.
Also there is an extra empty line (15).

Code-wise it looks ok, but please check those visual improvements too.

Thanks

bserem’s picture

bserem commented
Status: Active » Needs work

It is still not properly indented.
(line 12, line 31)

bserem’s picture

bserem commented

I still see a couple of lines that do not look ok, maybe my eyes are playing tricks.

Ping me on Slack so as to see if your editor is mixing stuff for you.

doxigo made their first commit to this issue’s fork.

  • doxigo committed ae6bde2 on 5.0.x authored by dimitriskr 
    Issue #3260596 by dimitriskr: Field template does not respect visually-...
doxigo’s picture

doxigo commented
Status: Needs work » Fixed

Thanks for the MR Dimitri and the quality control bill, this is merged, I'll fix the indentation if any later on and will push to codebase

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.