Problem/Motivation
Config schema for effects are missing.
Steps to reproduce
Install config inspector and create image style with imagick effects, you can see a lot of errors with missing schema.
Proposed resolution
Implements schema per image effect plugin.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | 3260342-imagick-config-schema--23.patch | 10.29 KB | svendecabooter |
Issue fork imagick-3260342
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
czigor commentedAdding config schema for the convert image effect. There's plenty more of these so not setting this to "needs review".
Comment #4
mxr576As the
image.effect.image_convertconfig schema is defined by the image.module therefore this module cannot override it because that still leads to config schema errors:The definition of the
extensionproperty gets removed by the patch #2.Comment #10
ivnishI added some schemas to image_blur and image_composite effects
Comment #11
ivnishComment #13
ivnishI commited some schemas to image_blur and image_composite effects. So, we need to add other schemas
Comment #16
mxr576kewl! This is fixed, now only crediting is missing and issue can be closed.
Comment #17
ivnishComment #18
ivnishThis is not fully fixed. See comment #13
Comment #22
svendecabooterI have now added config schema definitions for all image effects.
Configuration forms for image effects could also be improved upon, e.g. to property mark required fields, define numeric ranges, etc..
These improvements could then also be mirrored via config validation in the schema.yml file.
However, that seems like something to be tackled in a different issue.
For now I have only added config validation, where it currently exists in the configuration forms, to make sure the form input and config data is in sync validation-wise.
Comment #23
svendecabooterAdding the MR diff as patch file, for Composer-based patching workflows.
Comment #24
svendecabooterComment #26
ivnish@svendecabooter awesome! Merged!
Comment #27
ivnish