Problem/Motivation

Config schema for effects are missing.

Steps to reproduce

Install config inspector and create image style with imagick effects, you can see a lot of errors with missing schema.

Proposed resolution

Implements schema per image effect plugin.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork imagick-3260342

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lamp5 created an issue. See original summary.

czigor’s picture

StatusFileSize
new510 bytes

Adding config schema for the convert image effect. There's plenty more of these so not setting this to "needs review".

mxr576 made their first commit to this issue’s fork.

mxr576’s picture

As the image.effect.image_convert config schema is defined by the image.module therefore this module cannot override it because that still leads to config schema errors:

>  [error]  Schema errors for image.style.open_graph_image with the following errors: image.style.open_graph_image:effects.3326f4a4-7222-4e7d-93f6-0b7c3f338050.data.extension missing schema 

The definition of the extension property gets removed by the patch #2.

ivnish made their first commit to this issue’s fork.

ivnish changed the visibility of the branch 3260342-schema to hidden.

ivnish changed the visibility of the branch 3260342-schema to active.

ivnish’s picture

I added some schemas to image_blur and image_composite effects

ivnish’s picture

Status: Active » Needs review

ivnish’s picture

Status: Needs review » Needs work

I commited some schemas to image_blur and image_composite effects. So, we need to add other schemas

  • ivnish committed 6a4f912c on 8.x-1.x
    Issue #3260342 by ivnish: Config schema for effects are missing (WIP)
    

mxr576’s picture

kewl! This is fixed, now only crediting is missing and issue can be closed.

ivnish’s picture

ivnish’s picture

This is not fully fixed. See comment #13

svendecabooter made their first commit to this issue’s fork.

svendecabooter changed the visibility of the branch 3260342- to hidden.

svendecabooter’s picture

Status: Needs work » Needs review

I have now added config schema definitions for all image effects.
Configuration forms for image effects could also be improved upon, e.g. to property mark required fields, define numeric ranges, etc..
These improvements could then also be mirrored via config validation in the schema.yml file.

However, that seems like something to be tackled in a different issue.
For now I have only added config validation, where it currently exists in the configuration forms, to make sure the form input and config data is in sync validation-wise.

svendecabooter’s picture

StatusFileSize
new10.29 KB

Adding the MR diff as patch file, for Composer-based patching workflows.

svendecabooter’s picture

Version: 8.x-1.x-dev » 2.0.x-dev

ivnish’s picture

@svendecabooter awesome! Merged!

ivnish’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.