Problem/Motivation

Sometimes you want to configure more than classes

Proposed resolution

Support setting attributes too

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3260042-pass.patch2.07 KBlarowlan
#2 3260042-fail.patch1.39 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new 3260042-fail.patch1.39 KB
new 3260042-pass.patch2.07 KB

The last submitted patch, 2: 3260042-fail.patch, failed testing. View results

rikki_iki’s picture

rikki_iki commented
Status: Needs review » Reviewed & tested by the community

This is great! Though if I configure it to add a 'hidden' attribute or similar the section is hidden and I can't see the 'add block' button lol, but it's probably an edge case and can be worked around with some custom CSS. Would be the same for adding a class that hides the section, so nothing new that this patch is introducing.

Code is good, patch applies, useful addition, marking RTBC.

  • larowlan committed a9262c1 on 8.x-1.x 
    Issue #3260042 by larowlan, rikki_iki: Add support for setting...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.