Problem/Motivation

Need add "Geofield Map" with "Geoaddress-ed Field" in paragraph multiple.

Steps to reproduce

When we used widget "Geofield Map" with "Geoaddress-ed Field" settings (Choose an existing field where to store the Searched / Reverse Geocoded Address) in paragraph multiple.

Each element has the same #ID

https://git.drupalcode.org/project/geofield_map/-/blob/8.x-2.x/src/Eleme...

The last paragraph added rewrite all other $element['#geoaddress_field']['field']

Proposed resolution

fix the module to have unique #id

CommentFileSizeAuthor
#5 patch-applied.png69.62 KBhimanshu_jhaloya
#2 3259368-fix-unique-id.patch933 byteshesslinger

Issue fork geofield_map-3259368

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hesslinger created an issue. See original summary.

hesslinger’s picture

hesslinger commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3259368-fix-unique-id.patch933 bytes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-2.71 » 8.x-2.x-dev
himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: Unassigned » himanshu_jhaloya

I will review the patch

himanshu_jhaloya’s picture

himanshu_jhaloya commented
StatusFileSize
new patch-applied.png69.62 KB

review the patch #2 applied cleanly

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
Status: Needs review » Reviewed & tested by the community

  • itamair committed 19cd8ee on 3.0.x 
    Issue #3259368 by himanshu_jhaloya, hesslinger: Set unique id on...
itamair’s picture

itamair commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed

Liked work done here and trusted the review. Committed into 3.0.x dev ... is going to be part of next GM release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.