Problem/Motivation

This is possible since 9.3. See https://www.drupal.org/node/3253744

Steps to reproduce

Proposed resolution

Remaining tasks

Update the minimum Drupal Core version to 9.3.X

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3258992_8.patch3.95 KBmkalkbrenner
#2 3258992.patch2.73 KBheddn

Issue fork facets-3258992

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 3258992.patch2.73 KB
idebr’s picture

idebr commented

Considering \Drupal::requestStack()->getMainRequest(); is available from 9.3.0, would this raise the minimum requirement for the Facets project to Drupal 9.3? If so, this should be changed in facets.info.yml

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

I think so. Yes, I'm pretty sure that is needed. Or alternatively, a version check could be added that calls one vs the other. Or a method_exists check could be used.

idebr’s picture

idebr commented
Title: Replace getMasterRequest with getMainRequest » [Drupal 9.3.x] Replace getMasterRequest() with getMainRequest()
Issue summary: View changes
Status: Needs review » Needs work

Let's update the minimum Drupal Core version to 9.3.x and postpone this issue until 9.2.x is no longer supported

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Didn't we prepare anything here?
https://git.drupalcode.org/project/facets/-/commit/28ccbe9

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
StatusFileSize
new 3258992_8.patch3.95 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Mostly the same approach but none of the changes are mine at this point so I think I can mark as RTBC.

  • mkalkbrenner committed d50177b on 2.0.x 
    Issue #3258992 by heddn, mkalkbrenner, idebr: [Drupal 9.3.x] Replace...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Reviewed & tested by the community » Fixed
idebr’s picture

idebr commented
Title: [Drupal 9.3.x] Replace getMasterRequest() with getMainRequest() » Replace getMasterRequest() with getMainRequest() for Drupal 9.3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

VinmayiSwamy made their first commit to this issue’s fork.