Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The files core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldLeft.php and core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldRight.php break PSR-2 and PSR-4 and cannot be autoloaded correctly.
Steps to reproduce
Proposed resolution
Determine if they are even needed anymore.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#3 | 3258009-3.patch | 1.7 KB | alexpott |
Issue fork drupal-3258009
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
alexpottThese classes broken plugin discovered because their namespaced class is \Drupal\migrate_state_active_test\Plugin\migrate\field\d7\FieldLeft and \Drupal\migrate_state_active_test\Plugin\migrate\field\d7\FieldRight but their locations are core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldLeft.php and core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldRight.php.
So the module name is wrong and the /d7/ is too.
Comment #3
alexpottThese were added in #2936365: Migrate UI - allow modules to declare the state of their migrations but I don't think they've actually been necessary for the tests to work as expected.
Comment #4
andypostI see no usage of this broken plugins
Comment #5
quietone CreditAttribution: quietone at PreviousNext commentedAgree, these are not used. Looks like I added them when I started playing with the test but migrate field plugins aren't needed by the test. Don't know what I was thinking.
Comment #8
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!