Problem/Motivation

Support php 8 would be great!

Steps to reproduce

go to bulk update exclude form, get a warning as below

Warning: foreach() argument must be of type array|object, string given in Drupal\Core\Render\Element\Tableselect::valueCallback()

Proposed resolution

pass empty array instead of empty string to default value property.

CommentFileSizeAuthor
#5 after-patch.png188.98 KBclarkssquared
#5 before-patch.png496.49 KBclarkssquared
#2 foreach-argument must be of type array-object-3256364-1.patch610 bytesmohamed nabawy

Issue fork bulk_update_fields-3256364

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mohamed nabawy created an issue. See original summary.

mohamed nabawy’s picture

mohamed nabawy commented
StatusFileSize
new foreach-argument must be of type array-object-3256364-1.patch610 bytes

here is a patch to fix this warning.

andregp’s picture

andregp commented
Status: Active » Needs review
proweb.ua’s picture

proweb.ua commented

#2 works

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before-patch.png496.49 KB
new after-patch.png188.98 KB

Hi Mohamed Nabawy,

I confirmed the issue was resolved when I applied patch #2 to the "Bulk Update Fields" module against Version 8.x-2.0-alpha4. Please see the screenshots attached.

For your review.
Thank you.

el1_1el made their first commit to this issue’s fork.

el1_1el opened merge request !8

  • el1_1el committed d20666cb on 8.x-2.x 
    Issue #3256364 by Mohamed Nabawy, clarkssquared, andregp, proweb.ua:...
el1_1el’s picture

el1_1el commented
Version: 8.x-2.0-alpha4 » 8.x-2.0-alpha6
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.