Describe your bug or feature request.

Currently, when using the "Buy x get Y" offer, the quantity is set to "0" early on refresh.

When managing prices via pricelist, no price is resolved for a quantity of 0, causing the order refresh to crash.

We have several ways of fixing this... But I believe not crashing when no price is resolved is a good compromise...

The alternative could be to skip resolving a price when the quantity is 0? Perhaps that makes more sense.

CommentFileSizeAuthor
#3 3253104-option-2-3.patch758 bytesjsacksick
#2 3253104-2.patch954 bytesjsacksick

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new 3253104-2.patch954 bytes
jsacksick’s picture

jsacksick commented
StatusFileSize
new 3253104-option-2-3.patch758 bytes

Attaching another approach. The first one doesn't seem to work as expected, need to investigate this more.

  • jsacksick committed 389a9d0 on 8.x-2.x 
    Issue #3253104 by jsacksick: Ensure a price is resolved before setting...

  • jsacksick committed e4163e9 on 3.0.x 
    Issue #3253104 by jsacksick: Ensure a price is resolved before setting...
jsacksick’s picture

jsacksick commented
Version: 3.0.x-dev » 8.x-2.x-dev
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.