Field mapping options in media type form are not sorted correctly

This will need some sort of automated test coverage.

Yeah, would this happen to work? Patch attached.

+++ b/core/modules/media/tests/src/FunctionalJavascript/MediaTypeCreationTest.php
@@ -102,6 +102,12 @@ class MediaTypeCreationTest extends MediaJavascriptTestBase {
+    $options = $this->xpath('//select[@name="field_map[attribute_1]"]/option');
+    $this->assertEquals('- Skip field -', $options[0]->getText());
+    $this->assertEquals('Name', $options[1]->getText());
+    $this->assertEquals('Test source', $options[2]->getText());

Couple small things:

1. To prevent fatal errors, we should also do $this->assertGreaterThanOrEqual(3, count($options)); before asserting the text of the options.
2. We should use assertSame() instead of assertEquals().

Sorry to kick it back, but otherwise this looks great to me and I would be more than happy to re-RTBC when these are fixed. :)

Thanks! Patch attached.

❤️ Thank you! Looks great. Back to RTBC we go!

We don't sort form items that often, would it be possible to get a before/after screenshot here?

Yeah, here's the example screenshots:

* Before: https://take.ms/LEtzV
* After: https://take.ms/iWDKl

Unrelated test failure.

Marking as RTBC as test failures are unrelated.

@dsdeiz, thanks for the screenshots but having them off d.o means they can go away. I have encountered this problem when reviewing older issues for the Bug smash initiative. Plus before and after screenshots should be in the Issue Summary so that reviewer do not have to hunt for them in comments.

Setting to NW for an issue summary update to have screenshots in the Issue Summary.

Cheers,

I added the screenshots images links bellow the title User interface changes in summary as suggested by @quietone on comment #20.

Theses screenshots was related by @dsdeiz on comment #8.

Back to RTBC

Saving issue credit.

Committed and pushed b3d036aacd to 10.1.x and 3d9eaebe71 to 10.0.x and 93a3045f5b to 9.5.x. Thanks!

Sorting makes sense to me here.

Will backport to 9.4.x once the branch is unfrozen...

Committed ec84527 and pushed to 9.4.x. Thanks!