Problem/Motivation
If I go to the Lingotek module settings, I can set that all content translations download in the same status as the source, always published or always unpublished.
If I set that as “always unpublished”, and download a node translation, the translation is downloaded as unpublished as expected.
However, If I set that as “always unpublished”, and download a taxonomy term translation, the translation is downloaded as published, which was not expected.
Steps to reproduce
- Enable taxonomy term translation for a vocabulary in Drupal content translation settings.
- Ensure the “status” is marked as translatable.
- Enable taxonomy term translation for that vocabulary in Lingotek content translation settings.
- In Lingotek settings, set that all content translations should be downloaded “always unpublished”.
- Roundtrip a taxonomy term for that vocabulary. It should be downloaded as “unpublished”.
Proposed resolution
If I set that content should be downloaded as “always unpublished”, a taxonomy term translation needs to respect that setting.
Remaining tasks
Patch with tests.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3247828-translation-published-status-4.patch | 10.53 KB | penyaskito |
| #4 | 3247828-translation-published-status-4.only-tests.patch | 8.84 KB | penyaskito |
Comments
Comment #2
penyaskitoComment #3
penyaskitoComment #4
penyaskitoAdded patch with tests. This would also fix other entities aside of taxonomy terms, e.g. Drupal commerce products.
Comment #7
hlopez commentedPatch tested by me and reviewed by @sowmiya_v, looks good! Thanks!
Comment #10
penyaskitoCommitted afae2fd and pushed to 3.8.x.
Cherry-picked be36c2a and pushed to 4.0.x. Thanks!