Move domain path logic from node submit handler to entity API level

I think it makes sense and should be implemented. I'll work on it.

Hi quadrexdev
This module is used in one of my projects with JSON:API and has problems mentioned in the task description.
I plan to start work on this in the next few days. Would you mind assigning this issue to me?
I plan to do these steps to fix the problem:

1. Create a field item and field widget objects for the domain path.
2. Add code for altering base field info for entities that support domain path. I think it will be the same solution as we already have in the path auto module.
3. Update the domain path auto module to make its fields available on the entity API level.

Hi, I have pushed part of the required changes that provide the ability to use domain path fields on the entity API level.
However, changes for the domain_pathauto aren't finished. We need to cover new code by tests and refactor it.
But that is the start of work on this issue.

Created the related MR for better visibility of the work that has been done.

Looks like a significant change.

Fixed in 2.x.

My local environment already had a number of base field overrides that tripped up field logic for 'path', for example:

core.base_field_override.node.page.path.yml

uuid: 01008d71-ae6a-431f-8137-5196c1da432e
langcode: en
status: true
dependencies:
  config:
    - node.type.page
  module:
    - path
id: node.page.path
field_name: path
entity_type: node
bundle: page
label: 'URL alias'
description: ''
required: false
translatable: false
default_value: {  }
default_value_callback: ''
settings: {  }
field_type: path

I'm not sure what triggers the creation of such base field override. However, the result was the domain_path widget was never applied and the node edit form triggered several warnings:

Warning: Undefined array key "domain_id" in Drupal\domain_path\DomainPathHelper->alterEntityForm() (line 71 of modules/contrib/domain_path/src/DomainPathHelper.php).
Warning: Trying to access array offset on null in Drupal\domain_path\DomainPathHelper->alterEntityForm() (line 71 of modules/contrib/domain_path/src/DomainPathHelper.php).

Hi @idebr, could you give a try to this issue's MR?

#3564844: Switch to using the default core path_alias table instead of the custom domain_path one

I was required to add a weight of 10 to the domain_path module to have its hooks processed after those of the path module.

domain_path_entity_base_field_info correctly fires after the path module, but the base field override from #14 still take precedence. For bundles without base overrides, the code works correctly.

The relevant code from \Drupal\Core\Entity\EntityFieldManager::buildBundleFieldDefinitions that overrides the base field definition is here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

Perhaps a more fool-proof approach is to add a property to the PathItem similar to pathauto? https://git.drupalcode.org/project/pathauto/-/blob/8.x-1.x/src/PathautoI...

Or rename the base field to 'domain_path' to prevent the clash altogether

This field override is not new. How come you are getting hit now?

Can't you get rid of that override in #14?

Looks like we should use the hook_entity_base_field_info_alter() hook.

@idebr, could you give a try to MR 62 and tell me if it fixes your problem?

EDIT:

In fact, it doesn't work. Looks like we will have to use a custom field name like domain_path.

MR 62 has been updated to use a new dedicated field name (domain_path). All tests are green.

Could you give it a try @idebr?