Problem/Motivation

I faced two issues on linkit module, when using links around image and when trying to remove the same link. This is related to #3158783: Links around media images break when edited, using Linkit and CKeditor & #3201405: Edit internal link and remove the URL breaks layout builder

Steps to reproduce

1- Add an image using CKEditor.
2- Add a link around the image.
3- Save the content.
4- You will have an error Drupal\Core\Entity\EntityStorageException: The "" entity type does not exist.
5- Try to edit the link and remove it.
6- It will clean the HTML attributes but the link will still exist, and the error will appear again.

Proposed resolution

Add the patch fixes from:

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release Varbase 9.0.9, varbase_editor-9.0.7

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3245893 by Odai Atieh: Fixed Linkit linking issues around Media entities and brakes Layout Builder behaviors
CommentFileSizeAuthor
#2 3245893-2.patch790 bytesodai atieh

Comments

Odai Atieh created an issue. See original summary.

odai atieh’s picture

Status: Active » Needs review
StatusFileSize
new790 bytes
rajab natshah’s picture

Title: Fix linkit links issues » Fix Linkit linking issues around Media entities and with Layout Builder
rajab natshah’s picture

Title: Fix Linkit linking issues around Media entities and with Layout Builder » Fix Linkit linking issues around Media entities and brakes Layout Builder behaviors
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: Unassigned » rajab natshah

  • Rajab Natshah committed d4406bb on 10.0.x
    Issue #3245893 by Odai Atieh: Fix Linkit linking issues around Media...

  • Rajab Natshah committed 52c349d on 9.0.x
    Issue #3245893 by Odai Atieh: Fix Linkit linking issues around Media...
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.