Added CSS Admin disable option in Layout Builder

Yes agreed, thanks.

I thought layout builder issue was resolved when I worked with Gin compat. Not sure other themes, though, or anything else I missed.

However perhaps we could simplify the checks, remove the option, and just hijack directly when the parent form is recognized as layout builder?

I am away from laptop now. I would leave it to you.

Option 1:
Please verify, when you dump the form array, is there anything that can be used to identify layout builder? If so, just disable directly admin_css setting. No need for route nor option. Last time I worked with GridStack, Slick Browser I had at least useful properties like fields.

Option 2:
If the above is helpless, willy nilly we go with route checks as you did, but please remove the option. Just hijack directly.

We should stop playing nice for sure :)

Thank you.

To completely disable Blazy css without side effects, we can hijack $admin_css variable to FALSE.

Perhaps after this line:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/Form/BlazyAd...

If meeting LB hijack $admin_css FALSE.

The obvious side effect is double checkboxes as seen in your capture.

Looks like we need to adjust the conditions at particular Elvis lines there, my faults, none yours.

But the suggested hijack will do for now.

Thanks.

Adding new arguments to the existing services might have 2 costs:

1. Might break extenders (sub-modules) unless they update it as well and or we are sure we have checked the entire Blazy ecosystem if none was affected.
2. WSOD without an empty hook_post_update to clear cache.

IIRC I had resolved the first by avoiding extending it, but not sure if I missed one.

The less riskier will be these:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/BlazyManager...

+  use Drupal\blazy\Blazy;

-   $current_route_name = $this->routeMatch->getRouteName();
-   $current_route_name = isset($current_route_name) ? $current_route_name : '';

+  $current_route_name = Blazy::routeMatch() ? Blazy::routeMatch()->getRouteName() : '';

+    $is_layout_builder  = str_starts_with($current_route_name, "layout_builder.");
+
+    if ($is_layout_builder) {
+      $admin_css = FALSE;
+    }

This will be likely the entirity of your patch.
Then you can get rid the arguments, tests, methods.

Your approach is undoubtedly better, but riskier to break the ecosystem unless you have time to check each sub-module :)

My faults :)

I put too many traps aka tests to help me avoid this kind of mistakes. Dealing with static methods is one of the problems here.

Untested, but perhaps we should add a new cloned method to BlazyManagerBase:

public function getRouteName() {
  return Blazy::routeMatch() ? Blazy::routeMatch()->getRouteName() : '';
}

We should improve this line in the future 3+, like using service calls. But not priority for now.

Then replace this line:

-    $current_route_name = Blazy::routeMatch() ? Blazy::routeMatch()->getRouteName() : '';
+   $current_route_name = $this->blazyManager->getRouteName();

Feel free to give a shot.

If still fails, feel free to elaborate more for other solutions, or please wait for me to get back to this later this weekend.

Thanks.

Sorry for getting back late :)

It appears the test complains about str_starts_with which accepts null, not empty string, when ::getRouteName() method passed:

+    $current_route_name = $this->blazyManager()->getRouteName();
+    $is_layout_builder  = str_starts_with($current_route_name, "layout_builder.");

Potential solutions:

• Changed to greedy strpos, yet forgiving, like here: https://git.drupalcode.org/project/slick/-/blob/8.x-2.x/src/SlickManager...
• Or better check !empty($current_route_name) && before executing str_starts_with?

Look good, thanks :)

If I may ask, I preferred your previous one, only negated:

+ $admin_css = !str_starts_with($current_route_name, "layout_builder.");

Less lines, since it returns bool. But okay, too, with the last one, no big deal :)

We also need a correct check. This will do:

+    if ($admin_css && !empty($current_route_name)) {
+      $admin_css = !str_starts_with($current_route_name, "layout_builder.");
+    }

Committed. Thank you for kind contribution and patience.