Problem/Motivation
FILE: ...ebsub/modules/entity_share_websub_hub/src/PublisherInterface.php
----------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
9 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
14 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
21 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
24 | ERROR | [x] Expected 1 blank line after function; 2 found
27 | ERROR | [x] The closing brace for the interface must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...pp/modules/custom/entity_share_websub/entity_share_websub.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...hare_websub/modules/entity_share_websub_hub/src/HubInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
7 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...entity_share_websub_subscriber/tests/src/Functional/LoadTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...y_share_websub_hub/src/EventSubscriber/NotificationProcessor.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
12 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...share_websub_hub/src/Plugin/views/field/SyndicatedCountField.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
46 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------
FILE: ...ct/app/modules/custom/entity_share_websub/src/SignatureTrait.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...-drupal-project/app/modules/custom/entity_share_websub/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 81 characters
7 | WARNING | Line exceeds 80 characters; contains 110 characters
8 | WARNING | Line exceeds 80 characters; contains 107 characters
15 | WARNING | Line exceeds 80 characters; contains 117 characters
----------------------------------------------------------------------
FILE: ...b/modules/entity_share_websub_hub/entity_share_websub_hub.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
63 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ty_share_websub_hub/src/Plugin/views/field/SyndicatedSummary.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
29 | ERROR | [x] Missing function doc comment
38 | ERROR | [x] Missing function doc comment
70 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...modules/entity_share_websub_hub/tests/src/Traits/ValuesTrait.php
----------------------------------------------------------------------
FOUND 17 ERRORS AND 1 WARNING AFFECTING 12 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
1 | ERROR | [ ] Missing required strict_types declaration
4 | ERROR | [x] There must be one blank line after the namespace
| | declaration
7 | WARNING | [x] Unused use statement
10 | ERROR | [x] Missing trait doc comment
11 | ERROR | [ ] Missing member variable doc comment
11 | ERROR | [ ] Class property $mock_topic should use lowerCamel
| | naming without underscores
13 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [ ] Class property $mock_secret should use lowerCamel
| | naming without underscores
15 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [ ] Class property $mock_subscriber should use
| | lowerCamel naming without underscores
17 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [ ] Class property $mock_email should use lowerCamel
| | naming without underscores
19 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [ ] Class property $mock_node should use lowerCamel
| | naming without underscores
21 | ERROR | [x] Missing function doc comment
29 | ERROR | [x] Expected 1 blank line after function; 0 found
30 | ERROR | [x] The closing brace for the trait must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ntity_share_websub_hub/src/Controller/SubscriptionController.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
13 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
42 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
42 | ERROR | [ ] Missing parameter comment
44 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ty_share_websub_hub/src/Plugin/views/filter/SyndicatedFilter.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
1 | ERROR | [ ] Missing required strict_types declaration
4 | ERROR | [x] There must be one blank line after the namespace
| | declaration
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...dules/entity_share_websub_subscriber/src/SubscriptionManager.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
10 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...tity_share_websub_subscriber/src/Form/CancelSubscriptionForm.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
93 | ERROR | [x] The first index in a multi-value array must be
| | on a new line
96 | ERROR | [x] Closing parenthesis of array declaration must be
| | on a new line
131 | WARNING | [x] '@TODO Use event subscriber.' should match the
| | format '@todo Fix problem X here.'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...odules/entity_share_websub_hub/entity_share_websub_hub.views.inc
----------------------------------------------------------------------
FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
6 | ERROR | [ ] Doc comment short description must be on a
| | single line, further text should be a separate
| | paragraph
6 | ERROR | [x] There must be exactly one blank line after the
| | file comment
12 | ERROR | [x] Expected 1 blank line before function; 2 found
70 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
93 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
114 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
152 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: 'standard'
153 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
155 | ERROR | [x] Functions must not contain multiple empty lines
| | in a row; found 2 empty lines
158 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...odules/entity_share_websub_hub/tests/src/Functional/LoadTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...modules/entity_share_websub_subscriber/src/Form/SettingsForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...s/entity_share_websub_hub/src/Plugin/views/filter/UserFilter.php
----------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
1 | ERROR | [ ] Missing required strict_types declaration
4 | ERROR | [x] There must be one blank line after the namespace
| | declaration
7 | WARNING | [x] Unused use statement
19 | ERROR | [x] Expected 1 space before opening brace; found 2
21 | ERROR | [x] Missing function doc comment
36 | ERROR | [x] Expected 1 blank line after function; 0 found
37 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...modules/entity_share_websub_hub/tests/src/Kernel/ContentTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...ub/modules/entity_share_websub_hub/src/SubscriptionInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...ntity_share_websub_hub/src/Plugin/views/filter/SummaryFilter.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
1 | ERROR | [ ] Missing required strict_types declaration
4 | ERROR | [x] There must be one blank line after the namespace
| | declaration
16 | ERROR | [x] Expected 1 space before opening brace; found 2
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ty_share_websub_subscriber/entity_share_websub_subscriber.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...y_share_websub/modules/entity_share_websub_hub/src/Publisher.php
----------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
4 | WARNING | [x] Unused use statement
9 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
29 | ERROR | [x] Expected 1 space between comma and type hint
| | "Subscription"; 2 found
29 | ERROR | [x] Expected one space after the comma, 2 found
36 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
53 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../modules/entity_share_websub_hub/entity_share_websub_hub.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...y_share_websub_subscriber/entity_share_websub_subscriber.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...hare_websub/modules/entity_share_websub_hub/src/Subscription.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
211 | WARNING | Node::load calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------
FILE: ...hare_websub_subscriber/src/Controller/SubscriptionController.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...es/entity_share_websub_hub/tests/src/Kernel/SubscriptionTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
133 | ERROR | The array declaration extends to column 115 (the limit
| | is 80). The array content should be split up over
| | multiple lines
----------------------------------------------------------------------
FILE: ...websub/modules/entity_share_websub_subscriber/src/Subscriber.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
14 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
125 | WARNING | [x] '@TODO Handle and log errors?' should match the
| | format '@todo Fix problem X here.'
142 | WARNING | [x] '@TODO Handle and log errors?' should match the
| | format '@todo Fix problem X here.'
209 | WARNING | [x] '@TODO Add abiity to override hub URL.' should
| | match the format '@todo Fix problem X here.'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...es/entity_share_websub_subscriber/src/Event/ContentSyncEvent.php
----------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
1 | ERROR | [ ] Missing required strict_types declaration
4 | ERROR | [x] There must be one blank line after the namespace
| | declaration
9 | ERROR | [x] Missing class doc comment
23 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1
| | found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ty_share_websub_hub/src/Plugin/views/field/SyndicatedByField.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
48 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../entity_share_websub/modules/entity_share_websub_hub/src/Hub.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
13 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...share_websub_hub/src/Plugin/views/field/SyndicatorEmailField.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
6 | WARNING | [x] Unused use statement
32 | ERROR | [x] Expected 1 blank line after function; 0 found
46 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ntity_share_websub_subscriber/src/EventSubscriber/ItemImport.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
8 | WARNING | [x] Unused use statement
12 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
42 | WARNING | [ ] Line exceeds 80 characters; contains 99
| | characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ebsub/modules/entity_share_websub_subscriber/src/BatchHelper.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
7 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
35 | WARNING | [x] '@TODO Create an event and use event subscriber
| | instead.' should match the format '@todo Fix
| | problem X here.'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...dules/entity_share_websub_hub/tests/src/Kernel/PublisherTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...les/entity_share_websub_hub/src/Plugin/views/field/UserField.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
30 | ERROR | [x] Missing function doc comment
39 | ERROR | [x] Missing function doc comment
56 | ERROR | [x] Expected 1 blank line after function; 0 found
70 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...tity_share_websub_subscriber/src/EventSubscriber/HubNotifier.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
15 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...are_websub_hub/src/Plugin/views/field/SyndicationStatusField.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...ity_share_websub_subscriber/src/SubscriptionRecordRepository.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
13 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...es/entity_share_websub_subscriber/src/SubscriptionRepository.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
14 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
FILE: ...ebsub/modules/entity_share_websub_hub/tests/src/Unit/HubTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...b_subscriber/src/Plugin/QueueWorker/SubscriptionRecordWorker.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: ...re_websub_subscriber/src/Plugin/QueueWorker/SubscriberWorker.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
---------------------------------------------------------------------
Issue fork entity_share_websub-3243294
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
grimreaperAlso found that an explicit dependency on user module was missing.
Comment #6
WebbehBased on #4 and #5, is this resolved? Moving to RTBC pending confirmation by the maintainer.
Comment #7
fathershawnYes - I was waiting for the most recent test to confirm: https://www.drupal.org/pift-ci-job/2512034