Problem/Motivation

PHP Fatal error: strict_types declaration must be the very first statement in the script in C:\inetpub\forms\web\modules\contrib\ldap\ldap_servers\ldap_servers.install on line 10

Steps to reproduce

Upgrading to 8.x-4.1 and run drush updb

Proposed resolution

Move declare(strict_types = 1); from line 10 to line 8 in ldap_servers.install

CommentFileSizeAuthor
#2 3242169-2.patch479 bytesjungle

Comments

wolfhowling created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Active » Needs review
StatusFileSize
new 3242169-2.patch479 bytes
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Issue summary: View changes

  • grahl committed 86873c5 on 8.x-4.x authored by jungle 
    Issue #3242169 by jungle: Strict type declaration must be the first...
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Fixed

Ah, that's unfortunate, phpcs wasn't smart enough there.

Thanks for the report, tagging a new release now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.