Problem/Motivation

Move CloudResourceTrait::getCloudConfigs() to CloudConfigPluginManagerInterface::getCloudConfigs()

CommentFileSizeAuthor
#5 3239900-5.patch7.86 KBxld
#3 3239900-3.patch7.89 KBxld

Issue fork cloud-3239900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

XLD opened merge request !422

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3239900-3.patch7.89 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD Thank you for the refactoring. I left my comment above. Could you please check it?

Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3239900-5.patch7.86 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 5fc2b38 on 4.x authored by XLD 
    Issue #3239900 by XLD, yas: Refactor CloudResourceTrait::getCloudConfigs...

yas closed merge request !422

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.