Problem/Motivation

The CSS Asset collector parses the theme's info file direct.
This bypasses hook_system_info_alter.

Steps to reproduce

Use hook_system_info_alter in a module to add entity_print info to a theme.
Note that it is ignored.

Proposed resolution

Use the theme extension list instead.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 3238429-5.patch7.24 KBlarowlan
#13 3238429-interdiff-5.txt1.43 KBlarowlan
#11 3238429-4.patch7.33 KBlarowlan
#11 3238429-interdiff-4.txt620 byteslarowlan
#8 3238429-3.patch7.33 KBlarowlan
#8 3238429-3-interdiff.txt679 byteslarowlan
#5 3238429-2.patch7.33 KBlarowlan
#5 3238429-fail.patch1.59 KBlarowlan
#5 3238429-interdiff.txt2.77 KBlarowlan
#2 3238429.patch4.56 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new 3238429.patch4.56 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3238429.patch, failed testing. View results

mstrelan’s picture

mstrelan commented

Patch looks ok to me once the tests are passing. Would be good to see a test-only patch where you implement entity_print_test_system_info_alter() without changing the constructor.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3238429-interdiff.txt2.77 KB
new 3238429-fail.patch1.59 KB
new 3238429-2.patch7.33 KB

Should be red/green

The last submitted patch, 5: 3238429-fail.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3238429-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3238429-3-interdiff.txt679 bytes
new 3238429-3.patch7.33 KB

Stray tab in services.yml 🤦‍♂️

Status: Needs review » Needs work

The last submitted patch, 8: 3238429-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dpi’s picture

dpi
Location Perth, Australia
commented

I noticed the test was changed significantly, do the changes mean we still cant do it in the infofile in addition to alter? If so this would be major version change as its feature removal.

I dont have a dog in this fight.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3238429-interdiff-4.txt620 bytes
new 3238429-4.patch7.33 KB

coding standards

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I'll wind back some of the test changes so there's coverage for both types

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3238429-interdiff-5.txt1.43 KB
new 3238429-5.patch7.24 KB

Winds back the test change to keep coverage for both info and alter

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

  • larowlan committed c5e6db2 on 8.x-2.x 
    Issue #3238429 by larowlan, mstrelan, dpi: Css Asset collector doesn't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.