Problem/Motivation

The numbered_thumbnail view mode from crossword_image plugin current does not support values in cells.

Sharing crossword images with hints my engage more people. So, this features may provide good value.

Steps to reproduce

* Create a crossword with hints [ https://www.drupal.org/project/crossword/issues/3232115 ] ;
* Use numbered_thumbnail view mode from crossword_image.
Hints are not displayed

Proposed resolution

Implement cell value support in crossword_image.

From my understanding, this issue may require time. No pressure of course.
Thanks for the great job done for this module so far.

CommentFileSizeAuthor
#3 Screen Shot 2021-10-04 at 10.44.02 AM.png5.74 KBdanflanagan8
#2 crossword--image-hints--3232703--2.patch15.45 KBdanflanagan8

Comments

afagioli created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Active » Needs review
StatusFileSize
new crossword--image-hints--3232703--2.patch15.45 KB

Here's a shot at adding hints to the numbered_thumbnail plugin. Note that to update the image for existing crossword puzzles, you may have to use the "Regenerate" form.

See docs here: https://www.drupal.org/docs/contributed-modules/crossword/crossword-sub-...

I also took this opportunity to refactor the other image plugins and fixed a deprecation and a bug with LB preview.

Automated tests are only so helpful when it comes to making sure the images actually look good. Some manual testing would be very much appreciated.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new Screen Shot 2021-10-04 at 10.44.02 AM.png5.74 KB

Here's a screenshot for the file I recently created to test hints.

  • danflanagan8 committed 36a4cc2 on 8.x-1.x 
    Issue #3232703 by danflanagan8: Cell values in image preview
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Needs review » Fixed

I'm feeling confident about the patch now and committed it.

afagioli’s picture

afagioli
Location Rome
commented

Sounds cool!
Looking forward to test it!

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented

Hi @afagioli,
This new feature is part of the new 8.x-1.3 release, so you can just update instead of trying to apply the patch.

afagioli’s picture

afagioli
Location Rome
commented

It works suberly

Congrats for the great job!

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented

I'm happy to hear it. Thank you for the excellent feature request. I look forward to more good ideas!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.