Problem/Motivation

Add the ability to retrieve purchased phone number information from twilio.
Add the ability to make voice calls.

Proposed resolution

Working on adding new service classes and tidy up existing code

Remaining tasks

I've applied to be a co-maintainer but haven't heard back yet. In the mean time I'll create an issue fork and commit my changes there.

User interface changes

Added key module support for SID and token.

API changes

New Voice and Numbers services.

Issue fork twilio-3232126

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lambic created an issue. See original summary.

lambic opened merge request !1

lambic’s picture

lambic commented
Status: Active » Needs review
yang_yi_cn’s picture

yang_yi_cn commented

The 

Voice:addBeep()

function requires beep.mp3 file which might cause the voice call to fail, if the site is local or not publicly accessible.

I couldn't find a free host to host such link publicly, so I'm gonna change the addBeep() to take a parameter of soundFileUrl.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Needs work
yang_yi_cn’s picture

yang_yi_cn commented
Assigned: lambic » Unassigned
Status: Needs work » Needs review

changed $number to be protected instead of private. Please review again.

  • shashank5563 committed 1fd80e87 on 8.x-1.x authored by lambic 
    Issue #3232126: Add voice and phone number management to 8.x version
shashank5563’s picture

shashank5563 commented
Status: Needs review » Reviewed & tested by the community
shashank5563’s picture

shashank5563 commented

@lambic, Thanks for your support. your code is merged in 8.x-1.0-alpha6 release.

So, Please review once again.

  • shashank5563 committed 1fd80e87 on 8.x.2.x authored by lambic 
    Issue #3232126: Add voice and phone number management to 8.x version
shashank5563’s picture

shashank5563 commented
Status: Reviewed & tested by the community » Fixed
shashank5563’s picture

shashank5563 commented
Status: Fixed » Closed (fixed)