Acceptance Criteria:

  1. Call Cloud Orchestrator from an external agent
  2. Re-consider lock mechanism
  3. Introducing queue
CommentFileSizeAuthor
#23 3231898-4.x-23.patch12.3 KBxld
#21 3231898-4.x-21.patch12.3 KBxld
#21 3231898-3.x-21.patch12.32 KBxld
#20 3231898-4.x-20.patch12.24 KBxld
#20 3231898-3.x-20.patch12.26 KBxld
#18 3231898-3.x-18.patch11.84 KBxld
#18 3231898-4.x-18.patch11.82 KBxld
#16 3231898-4.x-16.patch11.73 KBxld
#16 3231898-3.x-16.patch11.75 KBxld
#15 3231898-4.x-15.patch11.73 KBxld
#14 3231898-3.x-14.patch11.75 KBxld
#12 3231898-3.x-12.patch11.27 KBxld
#12 3231898-4.x-12.patch11.25 KBxld
#9 3231898-4.x-9.patch11.27 KBxld
#7 3231898-7.patch11.26 KBxld
#5 3231898-5.patch10.95 KBxld

Issue fork cloud-3231898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

xld’s picture

xld commented
Status: Active » Needs work

XLD opened merge request !381

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Implement a Cron Job for VmWare » Add VMware cron job
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-5.patch10.95 KB

@yas, all the other QW use this Trait to gain access to the logger so, to align the code, I went for it but if you'd like me to refactor the QW to use DI directly, please advise.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I posted my comments above. Please check them. Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-7.patch11.26 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I found I had one more request to fix. Could you please check it?

Also, could you please create the patch for 3.x separately? Thanks!

xld’s picture

xld commented
StatusFileSize
new 3231898-4.x-9.patch11.27 KB

XLD opened merge request !407

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@XLD

Thank you for the update. I posted my comments regarding the log channel.. Could you please check the ones? Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-4.x-12.patch11.25 KB
new 3231898-3.x-12.patch11.27 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I posted my comments. Thanks!

xld’s picture

xld commented
StatusFileSize
new 3231898-3.x-14.patch11.75 KB
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-4.x-15.patch11.73 KB
xld’s picture

xld commented
StatusFileSize
new 3231898-3.x-16.patch11.75 KB
new 3231898-4.x-16.patch11.73 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I tested the patch and it looks working correctly now. On my second thought after checking Recent log messages on my testing Drupal site, could you please align the log channel from vmware to vmware_service? Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-4.x-18.patch11.82 KB
new 3231898-3.x-18.patch11.84 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I left my comments. Please check them. Thanks

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3231898-3.x-20.patch12.26 KB
new 3231898-4.x-20.patch12.24 KB

I've made the changes and am now using abstraction. Also, please note that the session ID is a string so I have also changed the annotation.

xld’s picture

xld commented
StatusFileSize
new 3231898-3.x-21.patch12.32 KB
new 3231898-4.x-21.patch12.3 KB
baldwinlouie’s picture

baldwinlouie commented

@yas and @XLD, Thank you for the patch. This one looks good to me.

xld’s picture

xld commented
StatusFileSize
new 3231898-4.x-23.patch12.3 KB

Rebased the 4.x version.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review.

@XLD

Thank you for updating the patch. I tested it works fine. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed ced692e on 3.x authored by XLD 
    Issue #3231898 by XLD, yas, baldwinlouie: Add VMware cron job

yas closed merge request !381

yas closed merge request !407

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed b4a14fa on 4.x authored by XLD 
    Issue #3231898 by XLD, yas, baldwinlouie: Add VMware cron job

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.