Problem/Motivation
dependencies:are not having the module name.smart_ip:smart_ip- Having a wrong
branch-aliasin the composer.json file - Having a not used assets repositories ( https://asset-packagist.org )
- No
package.jsonfile. - No
phpcs.xmlfile. - No
.gitignorefile.
drupal-check
analysis and Check deprecations
drupal-check -ad /var/www/html/dev/drupal9standard/web/modules/smart_ip_locale
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ --------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpDeleteForm.php
------ --------------------------------------------------------------------------------------
34 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
55 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
67 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
71 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpForm.php
------ --------------------------------------------------------------------------------
180 Variable $key might not be defined.
183 Variable $key might not be defined.
------ --------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Plugin/LanguageNegotiation/IpLanguageNegotiationLanguageNegotiationlocale.php
------ -----------------------------------------------------------------------------------------------------------------------------------
31 Right side of && is always true.
------ -----------------------------------------------------------------------------------------------------------------------------------
[ERROR] Found 7 errors
Proposed resolution
Have standard format for the module.
Remaining tasks
- None
User interface changes
- None
API changes
- None
Data model changes
- None
Comments
Comment #3
rajab natshahyarn phpcs
yarn phpcbf
Comment #4
rajab natshahComment #5
rajab natshahComment #7
rajab natshahdrupal-check
analysis and Check deprecations
drupal-check -ad /var/www/html/dev/drupal9standard/web/modules/smart_ip_locale
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ --------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpDeleteForm.php
------ --------------------------------------------------------------------------------------
34 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
55 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
67 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
71 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpForm.php
------ --------------------------------------------------------------------------------
180 Variable $key might not be defined.
183 Variable $key might not be defined.
------ --------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Plugin/LanguageNegotiation/IpLanguageNegotiationLanguageNegotiationlocale.php
------ -----------------------------------------------------------------------------------------------------------------------------------
31 Right side of && is always true.
------ -----------------------------------------------------------------------------------------------------------------------------------
[ERROR] Found 7 errors
Comment #9
rajab natshahdrupal-check
Comment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshah