Problem/Motivation

  • dependencies: are not having the module name. smart_ip:smart_ip
  • Having a wrong branch-alias in the composer.json file
  • Having a not used assets repositories ( https://asset-packagist.org )
  • No package.json file.
  • No phpcs.xml file.
  • No .gitignore file.

drupal-check

analysis and Check deprecations

drupal-check -ad /var/www/html/dev/drupal9standard/web/modules/smart_ip_locale
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------- 
  Line   dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpDeleteForm.php  
 ------ -------------------------------------------------------------------------------------- 
  34     Access to an undefined property                                                       
         Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.                   
  55     Access to an undefined property                                                       
         Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.                   
  67     Access to an undefined property                                                       
         Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.                   
  71     Access to an undefined property                                                       
         Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.                   
 ------ -------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------- 
  Line   dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpForm.php  
 ------ -------------------------------------------------------------------------------- 
  180    Variable $key might not be defined.                                             
  183    Variable $key might not be defined.                                             
 ------ -------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   dev/drupal9standard/web/modules/smart_ip_locale/src/Plugin/LanguageNegotiation/IpLanguageNegotiationLanguageNegotiationlocale.php  
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  31     Right side of && is always true.                                                                                                   
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 [ERROR] Found 7 errors                         

Proposed resolution

Have standard format for the module.

Remaining tasks

  • None

User interface changes

  • None

API changes

  • None

Data model changes

  • None

Comments

RajabNatshah created an issue. See original summary.

  • RajabNatshah committed 08881f0 on 8.x-1.x
    Issue #3228161: Construct the Smart IP - Language Detection and...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review

yarn phpcs

rajab@vardot-dev:/var/www/html/products/smart_ip_locale$ yarn phpcs
yarn run v1.22.10
$ phpcs --standard=./.phpcs.xml .
Done in 0.36s.

yarn phpcbf

rajab@vardot-dev:/var/www/html/products/smart_ip_locale$ yarn phpcbf
yarn run v1.22.10
$ phpcbf --standard=./.phpcs.xml .

No fixable errors were found

Time: 122ms; Memory: 10MB

Done in 0.21s.
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 270b2fe on 8.x-1.x
    Issue #3228161: Construct the Smart IP - Language Detection and...
rajab natshah’s picture

Issue summary: View changes

drupal-check

analysis and Check deprecations

drupal-check -ad /var/www/html/dev/drupal9standard/web/modules/smart_ip_locale
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpDeleteForm.php
------ --------------------------------------------------------------------------------------
34 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
55 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
67 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
71 Access to an undefined property
Drupal\smart_ip_locale\Form\NegotiationIpDeleteForm::$country_code.
------ --------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Form/NegotiationIpForm.php
------ --------------------------------------------------------------------------------
180 Variable $key might not be defined.
183 Variable $key might not be defined.
------ --------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------------------
Line dev/drupal9standard/web/modules/smart_ip_locale/src/Plugin/LanguageNegotiation/IpLanguageNegotiationLanguageNegotiationlocale.php
------ -----------------------------------------------------------------------------------------------------------------------------------
31 Right side of && is always true.
------ -----------------------------------------------------------------------------------------------------------------------------------

[ERROR] Found 7 errors

  • RajabNatshah committed ee69270 on 8.x-1.x
    Issue #3228161: Construct the Smart IP - Language Detection and...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem

drupal-check

drupal-check -ad /var/www/html/dev/drupal9standard/web/modules/smart_ip_locale
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors        
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue tags: +Drupal 9 compatibility
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.