Problem/Motivation

The Module loads aos.js froon unpkg.com. that should not be done anymore since GDPR forces people to make sure get consent befor connect to external serves

Steps to reproduce

install module
check source tab

Proposed resolution

  • Add it to the module or to libraries and change /bootstrap_styles/bootstrap_styles.libraries.yml so that the js file is no longer loaded from a cdn.
  • Switch to local when having the /libraries/aos/dist/aos.js and /libraries/aos/dist/aos.css in the PROJECT_PATH/libraries folder
  • A new config settings option will work for sure. not to keep using file_exists .. it could be a bootstrap_styling.setting value to use aos.remote or aos.local library in the PROJECT_PATH/libraries folder

Remaining tasks

  • ✅ Patch provided
  • ❌ Test
  • ❌ Review
  • ❌ Release

User interface changes

  • None

API changes

  • None

Data model changes

  • None
CommentFileSizeAuthor
#6 3226788-6.patch1.72 KBrajab natshah
#4 3226788-4.patch1.68 KBrajab natshah

Comments

Joachim Namyslo created an issue. See original summary.

joachim namyslo’s picture

Title: Provide aos.js locally to not vaiolate GDPR » Provide aos.js localy to not violate GDPR
Issue summary: View changes
joachim namyslo’s picture

Issue summary: View changes
rajab natshah’s picture

StatusFileSize
new1.68 KB
rajab natshah’s picture

Version: 1.0.3 » 1.0.x-dev
Status: Active » Needs review
rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new1.72 KB

Another patch with another way to do this with

# scroll_effects
plugin.scroll_effects.build:
  dependencies:
    - aos.remote

# AOS remote library.
aos.remote:
  remote: https://michalsnik.github.io/aos
  version: 1.x
  license:
    name: MIT
    url: https://github.com/michalsnik/aos/blob/master/LICENSE
    gpl-compatible: true
  js:
    https://unpkg.com/aos@2.3.1/dist/aos.js: { type: external, weight: -3, minified: true }
    js/plugins/scroll_effects/build.js: { }
  css:
    theme:
      https://unpkg.com/aos@2.3.1/dist/aos.css: { }

# AOS local library.
aos.local:
  js:
    /libraries/aos/dist/aos.js: { weight: -3, minified: true }
    js/plugins/scroll_effects/build.js: { }
  css:
    theme:
      /libraries/aos/dist/aos.css: { minified: true }

Switch to local when having the /libraries/aos/dist/aos.js in the PROJECT_PATH/libraries folder
A new config settings option will work for sure. not to keep using file_exists .. it could be a bootstrap_styling.setting value to use aos.remote or aos.local library

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • mahmoud-zayed committed 7fa5283 on 2.0.x
    Issue #3226788 by Rajab Natshah: Provide aos.js localy to not violate...

  • mahmoud-zayed committed 1a7dd2c on 1.0.x
    Issue #3226788 by Rajab Natshah, mahmoud-zayed: Provide aos.js localy to...
mahmoud-zayed’s picture

Status: Needs review » Fixed
mahmoud-zayed’s picture

Status: Fixed » Closed (fixed)