Problem/Motivation
The Module loads aos.js froon unpkg.com. that should not be done anymore since GDPR forces people to make sure get consent befor connect to external serves
Steps to reproduce
install module
check source tab
Proposed resolution
- Add it to the module or to libraries and change /bootstrap_styles/bootstrap_styles.libraries.yml so that the js file is no longer loaded from a cdn.
- Switch to local when having the
/libraries/aos/dist/aos.jsand/libraries/aos/dist/aos.cssin the PROJECT_PATH/libraries folder - A new config settings option will work for sure. not to keep using file_exists .. it could be a bootstrap_styling.setting value to use
aos.remoteoraos.locallibrary in the PROJECT_PATH/libraries folder
Remaining tasks
- ✅ Patch provided
- ❌ Test
- ❌ Review
- ❌ Release
User interface changes
- None
API changes
- None
Data model changes
- None
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3226788-6.patch | 1.72 KB | rajab natshah |
| #4 | 3226788-4.patch | 1.68 KB | rajab natshah |
Comments
Comment #2
joachim namysloComment #3
joachim namysloComment #4
rajab natshahComment #5
rajab natshahComment #6
rajab natshahAnother patch with another way to do this with
Switch to local when having the
/libraries/aos/dist/aos.jsin the PROJECT_PATH/libraries folderA new config settings option will work for sure. not to keep using
file_exists.. it could be a bootstrap_styling.setting value to useaos.remoteoraos.locallibraryComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshahComment #10
rajab natshahComment #13
mahmoud-zayed commentedComment #14
mahmoud-zayed commented