Olivero: Update links in block--secondary-menu.html.twig template file path drupal/core/themes/olivero/templates/block/block--secondary-menu.html.twig

We have two URL's in this file
* See http://juicystudio.com/article/screen-readers-display-none.php and
* http://www.w3.org/TR/WCAG-TECHS/H42.html for more information.

Both of them have been shifted to https, We should update in our file too.

CommentFileSizeAuthor
#10 interdiff.txt794 byteslauriii
#7 3226019_interdiff_3_6.txt727 byteshmendes
#6 3226019-6.patch4.09 KBhmendes
#4 status-message.png79.14 KBIndrajithKB
#3 3226019-3.patch3.38 KBGauravvvv
#2 3226019-2.patch832 bytesGauravvvv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gauravmahlawat created an issue. See original summary.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commented
Status: Active » Needs review
FileSize
3226019-2.patch832 bytes

Updated both the URL's and added patch for same. Please review.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commented
FileSize
3226019-3.patch3.38 KB

Updated URL's on all the templates.

IndrajithKB’s picture

IndrajithKB CreditAttribution: IndrajithKB at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Needs work
FileSize
status-message.png79.14 KB

Hi @Gauravmahlawat nice catch,
We have one more file which need to change the http to https.

image

File location: templates/misc/status-messages.html.twig

Moving to NR

IndrajithKB’s picture

IndrajithKB CreditAttribution: IndrajithKB at Srijan | A Material+ Company for Drupal India Association commented
Title: Olivero: Update links in block--secondary-menu.html.twig template file » Olivero: Update links in template file
hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented
Category: Support request » Task
Status: Needs work » Needs review
FileSize
3226019-6.patch4.09 KB

Adding a new patch to address #4, please review.

hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented
FileSize
3226019_interdiff_3_6.txt727 bytes

Sorry, forgot to add interdiff.

IndrajithKB’s picture

IndrajithKB CreditAttribution: IndrajithKB at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

Hi @hmendes thanks for the patch. Now the links were updated. So moving to RTBC

  • lauriii committed 4f9d375 on 9.3.x 
    Issue #3226019 by Gauravmahlawat, hmendes, Indrajith KB: Olivero: Update...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed
FileSize
interdiff.txt794 bytes

Made one minor change on commit to make line break comply with Drupals coding standards.

Committed 4f9d375 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.