Olivero: Skip link fails accessibility color test on hover.

Background color for skip link is #0D1214 and foreground color is #0D77B5.

This is failing accessibility test.

CommentFileSizeAuthor
Screenshot 2021-07-30 at 2.52.12 PM.png108.61 KBgauravvvv
Screenshot 2021-07-30 at 2.51.38 PM.png21.41 KBgauravvvv

Issue fork drupal-3226010

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravmahlawat created an issue. See original summary.

mariohernandez’s picture

mariohernandez commented

What should the hover color for skip link be? Would white do it?

mariohernandez’s picture

mariohernandez commented
Assigned: Unassigned » mariohernandez
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue tags: +Accessibility

Good catch!

mariohernandez’s picture

mariohernandez commented

Hey @mherchel first time contributing to Olivero. Do I simply commit changes to the *.pcss.css file or do I also commit updates to the plain *.css file?

mariohernandez opened merge request !1032

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented

Hello @mariohernandez, the answer on your question is here

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Yep! Both PCSS and CSS should be committed. If DrupalCI's compiled output is different than what you upload, tests will fail.

See the link from @kostyashupenko.

Also, you'll want to run yarn lint:css to ensure that there's no whitespace or ordering issues. Feel free to ping me in Slack #olivero anytime.

mariohernandez’s picture

mariohernandez commented
Status: Active » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

Tests are failing because the compiled CSS output doesn't match what the MR contains. You'll want to run yarn build:css one more time, and then commit the resulting file.

Other than that, this looks great!

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

mariohernandez’s picture

mariohernandez commented

Sorry I was late to correct the linter issue.

  • lauriii committed 4313e7f on 9.3.x 
    Issue #3226010 by mariohernandez, kostyashupenko, Gauravmahlawat,...

  • lauriii committed f6d8825 on 9.2.x 
    Issue #3226010 by mariohernandez, kostyashupenko, Gauravmahlawat,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 4313e7f and pushed to 9.3.x. Also cherry-picked to 9.2.x because Olivero is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.