Problem/Motivation

PHP 7.2 compatibility: trailing commas in method calls not supported

Proposed resolution

Remove trailing commas in method calls in tests.

Remaining tasks

Patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3224238-php-72-compatibility-trailing-commas-2.patch1.47 KBpenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3224238-php-72-compatibility-trailing-commas-2.patch1.47 KB

Attached patch.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Tests passed.

  • penyaskito committed 76e8665 on 3.7.x 
    Issue #3224238 by penyaskito: PHP 7.2 compatibility: trailing commas in...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed 76e8665 and pushed to 3.7.x. Thanks!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Category: Bug report » Task

  • penyaskito committed 9cdc830 on 3.7.x 
    Issue #3224238 by penyaskito: PHP 7.2 compatibility: trailing commas in...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

There were some other instances of the same issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.