Problem/Motivation

Currently requests to the queue trigger endpoint are getting cached even if they contain different end times.

That query parameter needs to be added to the cache context for the build.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork govdelivery_bulletins-3223883

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swirt created an issue. See original summary.

Elijah Lynn made their first commit to this issue’s fork.

Elijah Lynn opened merge request !2

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

I've pushed the changes that acrollet, swirtMiles and I just worked on to the fork, which adds a cache context for the 'EndTime' query parameter as it was getting cached and changing the param didn't bust the cache.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

We also changed the request to use the magic sauce here https://www.drupal.org/docs/8/api/routing-system/parameters-in-routes/us....

acrollet’s picture

acrollet commented

Referencing this core issue that documents why changed query parameters do not invalidate the dynamic page cache: https://www.drupal.org/project/drupal/issues/2877498

  • Elijah Lynn committed e9f8324 on 8.x-1.x 
    #3223883: Add query param EndTime to cache context for route controller.
swirt’s picture

swirt
he/him
Primary language English
commented
Status: Active » Fixed

Thank you @Elijah Lynn and @acrollet for your contribution and your continued path to excellence.

swirt’s picture

swirt
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)