Problem/Motivation

We should explicitly make destination plugins final, and mark \Drupal\migmag_rollbackable\Plugin\migrate\destination\RollbackableComponentEntityDisplayBaserollbackable destination plugin base class 'internal'.

We also have to add missing provider annotations for:

  1. RollbackableColor (because the base plugin is provided by the Color module)
  2. RollbackableDefaultLangcode (because the base plugin is provided by the Language module)

Proposed resolution

  1. ✅ Declare destination plugin classes as final.
  2. ✅ Mark plugin base class RollbackableComponentEntityDisplayBase as @internal.
  3. ✅ Update documentation (and refer it in hook help implementation).

Remaining tasks

No doc change needed.

API changes

Nothing.

CommentFileSizeAuthor
#6 interdiff-3223449-4-6.txt2.05 KBhuzooka
#6 migmag-final_internal_provider_fixes-3223449-6.patch8.13 KBhuzooka
#4 interdiff-3223449-2-4.txt2.25 KBhuzooka
#4 migmag-final_internal_provider_fixes-3223449-4.patch6.08 KBhuzooka
#2 migmag-final_internal_destination_plugin_classes-3223449-2.patch4.85 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new migmag-final_internal_destination_plugin_classes-3223449-2.patch4.85 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: Unassigned » huzooka
Issue summary: View changes
Status: Needs review » Needs work
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
StatusFileSize
new migmag-final_internal_provider_fixes-3223449-4.patch6.08 KB
new interdiff-3223449-2-4.txt2.25 KB

Documentation references also should be updated.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new migmag-final_internal_provider_fixes-3223449-6.patch8.13 KB
new interdiff-3223449-4-6.txt2.05 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Title: Mark rollbackable destination plugin base classes 'internal', and make destination plugins final » Mark RollbackableComponentEntityDisplayBase 'internal', make destination plugins final, and update documentation

  • huzooka committed a0a8da6 on 1.0.x 
    Issue #3223449 by huzooka: Mark RollbackableComponentEntityDisplayBase '...
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Component: Code » Rollbackable Destination Plugins
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.