CommentFileSizeAuthor
#29 3222352-29.patch39.08 KBxld
#27 dev1.dataninja.net_clouds_design_server_template_cloudopt_k8s_1_36_edit(MacBook Air).png915.85 KByas
#25 3222352-25.patch30.33 KBxld
#24 dev1.dataninja.net_clouds_design_server_template_cloudopt_k8s_1_36.png458.1 KByas
#19 3222352-19.patch23.74 KBxld
#17 3222352-17.patch23.74 KBxld
#15 3222352-15.patch23.63 KBxld
#13 3222352-13.patch17.6 KBxld
#11 3222352-11.patch17.6 KBxld
#5 3222352-5.patch23.63 KBxld
#4 20210723b.png413.59 KByas
#4 20210723a.png648.41 KByas
#3 3222352-3.patch18.85 KBxld

Issue fork cloud-3222352

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

XLD opened merge request !320

xld’s picture

xld commented
Status: Active » Needs review
StatusFileSize
new 3222352-3.patch18.85 KB

@yas Please review my work. Also, please run a drush updb before testing.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new 20210723a.png648.41 KB
new 20210723b.png413.59 KB

@XLD

Thank you for the patch. I tested the patch and it looks good. I would like to ask you to update the forms as the following screenshots:

20210723a.png

20210723b.png

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-5.patch23.63 KB

@yas

I have made the required changes and tested with both a public and a private Github repo.
Please review my patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed e4205cc on 4.x authored by XLD 
    Issue #3222352 by XLD, yas: Support access tokens for GitHub operations

yas closed merge request !320

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

XLD opened merge request !336

xld’s picture

xld commented
Status: Fixed » Needs review
StatusFileSize
new 3222352-11.patch17.6 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3222352-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-13.patch17.6 KB

Status: Needs review » Needs work

The last submitted patch, 13: 3222352-13.patch, failed testing. View results

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-15.patch23.63 KB
xld’s picture

xld commented
Status: Needs review » Needs work
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-17.patch23.74 KB
xld’s picture

xld commented
Status: Needs review » Needs work
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-19.patch23.74 KB
xld’s picture

xld commented
Status: Needs review » Needs work
xld’s picture

xld commented
xld’s picture

xld commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. I posted my comments above. Please check the ones. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new dev1.dataninja.net_clouds_design_server_template_cloudopt_k8s_1_36.png458.1 KB

@XLD

Thank you for the update. Please see the screenshot as my comments requesting the cosmetic changes:

36.png

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-25.patch30.33 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the update. As I commented in the screenshot above, please change the fieldset's label depending on the source type such as Git, GitHub, and GitLab.

See also: 6.png

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
StatusFileSize
new dev1.dataninja.net_clouds_design_server_template_cloudopt_k8s_1_36_edit(MacBook Air).png915.85 KB

@XLD

Also, could you please switch Git Account and Source fieldset in the edit screen (also the canonical (detailed) view, too? --- The canonical view can be the same, though)

9.png

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3222352-29.patch39.08 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed b52c30c on 4.x authored by XLD 
    Issue #3222352 by XLD, yas: Support access tokens for GitHub operations

yas closed merge request !336

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.