Fix spelling for words used once, beginning with 'n' -> 'p', inclusive

This one applies apart from to dictionary.txt, so should be fairly easy to reroll.

Patch no longer applies to 10.1

If someone doesn't beat me to it I can update later today.

Rerolled for D10

Two nits, otherwise this looks good:

1. +++ b/core/lib/Drupal/Core/Config/ConfigFactoryOverrideInterface.php
   @@ -36,7 +36,7 @@ public function getCacheSuffix();
   +   * and synchronization to use the over-rider's implementation of
   

   "overrider" is a word, one who overrides? This looks off to me with the added hyphen. I think this one should be ignored instead.

2. +++ b/core/tests/Drupal/Tests/Component/EventDispatcher/ContainerAwareEventDispatcherTest.php
   @@ -13,6 +13,7 @@
   +// cspell:ignore postbar
   

   This is a single constant in the file but it doesn't actually seem to be used, maybe we can just remove it?

Addressed point #14.1 with "overriders" sounded right when I said it out loud at least
#14.2 it's actually used as the name of a variable on the page.

For #14.2 I see it's used as const POSTBAR = 'post.bar'; but this looks like dead code, so we can remove it and the ignore?

Patch #15 is working fine for me in drupal version 10.1.x and fixing word (n to p),
i refer to txt file after patch apply

Thank you.

@longwave you are correct. Removed the variable cspell line.

Thanks, this looks ready to go.

Thanks for working on this spelling issue! I have a number of corrections, plus two suggestions for things that should get their own issues.

1. +++ b/core/lib/Drupal/Core/Config/ConfigBase.php
   @@ -9,6 +9,8 @@
   +// cspell:ignore ntfs
   +
   

   "NTFS" is a legitimate technology term for a file system. I think we should retain it in the dictionary.

2. +++ b/core/lib/Drupal/Core/Config/ConfigFactoryOverrideInterface.php
   @@ -36,7 +36,7 @@ public function getCacheSuffix();
   -   * and synchronization to use the overrider's implementation of
   +   * and synchronization to use the overriders implementation of
   

   This is not a grammatically correct change. I would suggest "the overriding _____'s implementation" (insert the correct noun).

3. +++ b/core/lib/Drupal/Core/Database/StatementPrefetch.php
   @@ -3,7 +3,7 @@
   - * An implementation of StatementInterface that prefetches all data.
   + * An implementation of StatementInterface that will prefetch all data.
   

   "prefetch" is not correct if "prefetches" isn't. It should instead be hyphenated: "pre-fetches".

4. +++ b/core/lib/Drupal/Core/Routing/RoutePreloader.php
   @@ -11,7 +11,7 @@
   - * Defines a class which preloads non-admin routes.
   + * Defines a class that can preload non-admin routes.
   

   Same problem here. "preload" is not a word if "preloads" is not a word. Let's hyphenate it as "pre-loads" instead.

5. +++ b/core/lib/Drupal/Core/Session/SessionManager.php
   @@ -7,6 +7,8 @@
   +// cspell:ignore owasp
   

   This is a legit technology term, critical in web security, and should be kept in the dictionary.

   https://owasp.org/

6. +++ b/core/modules/path/tests/src/Kernel/Migrate/d7/MigrateUrlAliasTestBase.php
   @@ -5,6 +5,8 @@
   +// cspell:ignore noslash
   +
    /**
   

   This word appears to just be related to test metadata. Let's update the test metadata instead? This could be split into its own issue.

7. +++ b/core/modules/serialization/tests/modules/test_fieldtype_boolean_emoji_normalizer/src/Normalizer/BooleanItemNormalizer.php
   @@ -29,7 +29,7 @@ public function normalize($object, $format = NULL, array $context = []): array|s
   -    // Just like \Drupal\serialization\Normalizer\FieldItemNormalizer's logic
   +    // Just like logic in \Drupal\serialization\Normalizer\FieldItemNormalizer
        // for denormalization, which uses TypedDataInterface::setValue(), allow the
        // keying by main property name ("value") to be implied.
   

   I would rewrite this comment entirely. The whole thing is really unclear, grammatically convoluted, and technically vague. Let's open a separate issue for it.

8. +++ b/core/modules/system/tests/modules/pager_test/src/Controller/PagerTestController.php
   @@ -39,7 +39,7 @@ public function __construct(PagerParametersInterface $pager_params) {
   +   * Builds a render array for a multi page test table.
   

   "multi-page" should be hyphenated.

9. +++ b/core/tests/Drupal/Tests/Component/EventDispatcher/ContainerAwareEventDispatcherTest.php
   @@ -32,7 +32,6 @@ class ContainerAwareEventDispatcherTest extends TestCase {
   -  const POSTBAR = 'post.bar';
   

   This seems out of scope or incorrect.

I have fixed the 2,3,4,8 suggestion which is mentioned in #20.

Attempted to address the other issues from #20.

Opened up 2 follow up tickets.

#20.9 it was pointed out that was dead code in #16

Am getting these phpstan errors now though

------ ------------------------------------------------
Line lib/Drupal/Core/Database/StatementPrefetch.php
------ ------------------------------------------------
212 Variable $query_start might not be defined.
212 Variable $query_start might not be defined.
------ ------------------------------------------------

------ ----------------------------------------------
Line lib/Drupal/Core/Session/SessionManager.php
------ ----------------------------------------------
148 Variable $session_data might not be defined.

maybe it was just me?

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

#22 no longer applied with
error: patch failed: core/lib/Drupal/Core/Database/StatementPrefetch.php:3
error: core/lib/Drupal/Core/Database/StatementPrefetch.php: patch does not apply

Mostly looking good, but a few problems remain:

1. +++ b/core/lib/Drupal/Core/Config/ConfigFactoryOverrideInterface.php
   @@ -36,7 +36,7 @@ public function getCacheSuffix();
   -   * and synchronization to use the overrider's implementation of
   +   * and synchronization to use the overriding _____'s implementation of
   

   Uhhh, @xjm was suggesting we fill this in with the right noun, not leave a bunch of blanks in the comment. 😂

   That said, given the rest of the comment, I'm not sure the suggestion is the way to go. I honestly think "overrider's implementation" makes the most sense, unless we completely rewrite this entire comment.

2. +++ b/core/lib/Drupal/Core/Database/StatementPrefetch.php
   @@ -8,7 +8,7 @@
   + * An implementation of StatementInterface that will pre-fetches all data.
   

   "that will pre-fetches all data." isn't grammatically correct.

   Either needs:

   "that will pre-fetch ..."
   or
   "that pre-fetches ..."
   but not both.

3. +++ b/core/lib/Drupal/Core/Routing/RoutePreloader.php
   @@ -11,7 +11,7 @@
   + * Defines a class that can pre-loads non-admin routes.
   

   Also not right.
   "that can pre-load ..."

Addressing #26

Think a file or two may be missing.

Hard to tell as the interdiff is the same as the patch.

I checked the patches (#25 and #27) and they are the same except the interdiff attached here.

Thanks!

Committed/pushed to 10.1.x, thanks!

I've run this command but it throwing error with the command failed and the dictionary got blanked.

Applied #37 and ran spellcheck:make-drupal-dict and didn't get any additional changes.

@quietone, The reason for the error was that Windows uses a different syntax for setting environment variables compared to Unix-based systems, The LC_ALL environment variable is specific to Unix-based systems, and it is not recognized in the same way on Windows which throws an error and its forcefully removing the content from the dictionary.txt file.

Working fine on Linux RTBC+1

Thanks for the reroll

Committed 031f63e and pushed to 11.x. Thanks!