Fix spelling for words used once, beginning with 'e' -> 'i', inclusive

Working on it

Re-rolled patch against 9.4.x

Thanks for rerolling. This looks close, with one question:

+++ b/core/modules/jsonapi/src/Normalizer/NormalizerBase.php
@@ -62,7 +62,7 @@ protected static function rasterizeValueRecursive($value) {
-    // for formatless normalization. The JSON:API module wants to be cautious.
+    // for format less normalization. The JSON:API module wants to be cautious.

I am not sure that "format less normalization" makes sense, but am also not sure what a better wording would be.

Works for me,

I re-reviewed all the other changes and they look correct so this is RTBC.

1. +++ b/core/modules/editor/src/Plugin/InPlaceEditor/Editor.php
   @@ -60,7 +60,7 @@ public function getMetadata(FieldItemListInterface $items) {
   -    return (bool) count(array_intersect([FilterInterface::TYPE_TRANSFORM_REVERSIBLE, FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE], $format->getFiltertypes()));
   +    return (bool) count(array_intersect([FilterInterface::TYPE_TRANSFORM_REVERSIBLE, FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE], $format->getFilterTypes()));
   

   +++ b/core/modules/user/tests/src/Functional/UserPictureTest.php
   @@ -116,7 +116,7 @@ public function testPictureOnNodeComment() {
   -    $image_url = \Drupal::service('file_url_generator')->transformRelative($style->buildUrl($file->getfileUri()));
   +    $image_url = \Drupal::service('file_url_generator')->transformRelative($style->buildUrl($file->getFileUri()));
   

   Ooh. If these were a class/trait/interface name and not a method name, it'd cause an actual bug on case-sensitive filesystems.

   Likewise these:

   +++ b/core/modules/system/tests/src/Functional/Mail/HtmlToTextTest.php
   @@ -194,7 +194,7 @@ public function testDrupalHtmlToTextArgs() {
   -  public function testDrupalHtmltoTextCollapsesWhitespace() {
   +  public function testDrupalHtmlToTextCollapsesWhitespace() {
   
   +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityApiTest.php
   @@ -211,7 +211,7 @@ public function testEntityStorageExceptionHandling() {
   -      $this->assertEquals(1, $e->getcode(), 'Entity presave EntityStorageException caught.');
   +      $this->assertEquals(1, $e->getCode(), 'Entity presave EntityStorageException caught.');
   
   +++ b/core/tests/Drupal/Tests/Core/Authentication/AuthenticationManagerTest.php
   @@ -49,7 +49,7 @@ public function testDefaultFilter($applies, $has_route, $auth_option, $provider_
   -  public function testApplyFilterWithFilterprovider() {
   +  public function testApplyFilterWithFilterProvider() {
   

2. +++ b/core/modules/block/migrations/d7_block.yml
   @@ -1,3 +1,4 @@
   +# cspell: ignore firstcolumn secondcolumn thirdcolumn fourthcolumn
   

   We can also remove "thirdcolumn" from the dictionary; it also only has this one file's instance plus a fixture that is already ignored:

   [ayrton:maintainer | Mon 11:58:32] $ grep -rl "thirdcolumn" *
   core/modules/migrate_drupal/tests/fixtures/drupal7.php
   core/modules/block/migrations/d7_block.yml

3. +++ b/core/modules/system/tests/src/Functional/Render/HtmlResponseAttachmentsTest.php
   @@ -69,7 +69,7 @@ public function testAttachments() {
   -    // Check that duplicate alternate URLs with different hreflangs are allowed.
   +    // Check that duplicate alternate URLs with different hreflang are allowed.
   

   This is awkward. Maybe "with different hreflang attributes"?

4. +++ b/core/tests/Drupal/Tests/Component/Utility/BytesTest.php
   @@ -6,6 +6,8 @@
   +// cspell:ignore giggabyte
   

   Isn't the correct spelling "Gigabyte"?

   ...Ah, a comment in the test explains:

         // 76.24 GB (with typo).                                                  
   

   Could we move the // cspell:ignore comment to be above the inline comment for clarity? Or do we have a best practice of putting these declarations at the top of the file?

5. +++ b/core/tests/Drupal/KernelTests/Core/Config/ConfigOverrideTest.php
   @@ -93,7 +93,7 @@ public function testConfOverride() {
   -      '404' => 'herpderp',
   +      '404' => 'herp derp',
   

   ...Does this mean that "herp" and "derp" are considered words upstream?

   ...No. "herp" is only in the dictonary because it is apparently short for "herptile" ("a reptile or amphibian", not what we mean), and "derp" because it's in our dictionary already. So this is essentially just moving technical debt around. Let's either ignore "herpderp" within this file, or use a different test string that meets the needs of the tests.

6. +++ b/core/tests/Drupal/KernelTests/Core/Plugin/InspectionTest.php
   @@ -3,7 +3,7 @@
   - * Tests that plugins implementing PluginInspectionInterface are inspectable.
   + * Tests plugins implementing PluginInspectionInterface can be inspected.
   

   The word "that" is still needed here.

7. +++ b/core/tests/Drupal/Tests/Core/File/FileSystemTest.php
   @@ -166,7 +166,7 @@ protected function assertFilePermissions(int $expected_mode, string $uri, string
   -    $filename = "a\xFFsdf\x80€" . '.txt';
   +    $filename = "a\xFFFoo\x80€" . '.txt';
   

   Hmm. I guess this is okay, but in general we shouldn't change test strings testing edgecases like this; it'd be better to add an ignore directive for them.

NW for points 2, 3, 5, 6, and maybe 4 above. Thanks!

> Could we move the // cspell:ignore comment to be above the inline comment for clarity? Or do we have a best practice of putting these declarations at the top of the file?

I don't think we have a strict rule about this. I do wonder if we should be using // cspell:ignore-next-line more often, as that would reduce some technical debt if we correct or remove a misspelled word but do not remove it from the top of the file at the same time.

@longwave, I worked on a few related issues and I agree that defining a standard for cspell:ignore would be much better.
I personally believe that // cspell:ignore <word> is better suitable for cases with multiple instances of the word throughout the code and // cspell:ignore-next-line is much better when the word appear only 1-2 times.

Rerolled patched #18 on Drupal 10.1.x, keeping the status needs work for comment #20.

I have made two changes according to #20 point 3 & 6. Still it needs work for other points.

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

Reviewing the list from the IS I'm no longer finding multiple instances (most have 0) in 10.1.x
Still found strings like 'fffffg' and the column stuff "firstcolumn"

All points from #20 appear to be addressed.

Is the standard for one liners to use // cspell:disable-next-line vs cspell:ignore xyz

+++ b/core/modules/system/tests/src/Functional/Form/FormTest.php
@@ -14,6 +14,8 @@
+// cspell:ignore fffffg
+

Could we move this above the relevant line, as the invalid value is only declared once?

Everything else looks great to me in this patch. Nice work!

Remarking

Committed to 10.1.x and 10.0.x, thanks!

It does not apply to 9.5.x, so we would need a different version for backport (merge conflict in the dictionary, plus there might be some instances of these words in removed code).

Interesting, how did #36 pass if there were all those words in #37 still needed?

When I apply #37 and regenerate the dictionary I get a different result.

1. Apply #37 to 9.5.x HEAD.
2. rm -rf vendor; composer install
3. cd core; rm -rf node_modules; yarn install
4. yarn spellcheck:make-drupal-dict

I get the attached changes to the dictionary.

This one kinda deviated from the original issue it seemed? (could be wrong) How best to review?

Applying patch #37 on 9.5.x
Running the steps from #40

I did not get the same changes.

@smustgrave, could you clarify which changes you do get, or upload the copy of the dictionary you got?

In particular, I'm concerned that @quietone's patch does not remove the dictionary entries for herpderp, hreflangs, etc. which are the target of the issue.

Here's my dictionary.txt file from #45

Changes look good to me.

I diffed #30 and #48 locally and the only changes are in dictionary.txt. I applied the patch and ran cspell locally and found no errors.

Committed and pushed to 9.5.x, thanks!