Tidy up code base.

Comments

johnv created an issue. See original summary.

  • johnv committed 8760800 on 8.x-1.x
    Issue #3219111: Cleaan code
    
johnv’s picture

Title: Cleaan code » Clean code

  • johnv committed 2e80e60 on 8.x-1.x
    Issue #3219111: Clean code - OfficeHoursSlot.php
    

  • johnv committed a0f6835 on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed e7c3ecf on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed 3c5d25d on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed e382ec3 on 8.x-1.x
    Issue #3219111 by johnv: Clean code
    

  • johnv committed 83c7db4 on 8.x-1.x
    Issue #3219111: Clean code - #element_validate
    

  • johnv committed 2807c3d on 8.x-1.x
    Issue #3219111: Clean code - #element_validate, default value [day,...

  • johnv committed a9a0d89 on 8.x-1.x
    Issue #3219111: Clean code - OfficeHoursFormatterTrait.php
    

  • johnv committed 4199465 on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed feb7f3c on 8.x-1.x
    Issue #3219111: Clean code - Isolate OfficeHoursItem::...

  • johnv committed c2ca563 on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed 628c8d7 on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed 0865a1f on 8.x-1.x
    Issue #3219111 by johnv: Clean code - small updates
    

  • johnv committed a5fa259 on 8.x-1.x
    Issue #3219111: Clean code - Introduce constant OfficeHoursDateHelper::...

  • johnv committed 33eb70b on 8.x-1.x
    Issue #3219111: Clean code - Remove $langcode parameter from Formatter::...

  • johnv committed 42ab83e on 8.x-1.x
    Issue #3219111: Clean code - Introduce constant OfficeHoursDateHelper::...

  • johnv committed cc67964 on 8.x-1.x
    Issue #3219111: Introduce constant OfficeHoursDateHelper::EMPTY_HOURS
    

  • johnv committed 1ac2ad8 on 8.x-1.x
    Issue #3219111: Clean code - add comment
    

  • johnv committed 4d28793 on 8.x-1.x
    Issue #3219111: Clean code
    

  • johnv committed cdbca0c on 8.x-1.x
    Issue #3219111: Clean code - phpcs
    
viniciuscosta’s picture

Hi, I am working on it. =)

viniciuscosta’s picture

Assigned: Unassigned » viniciuscosta
johnv’s picture

Assigned: viniciuscosta » johnv
Status: Active » Postponed

Thanks, but please don't.
I will not solve many of the remarks, due to personal preferences.

  • johnv committed 1acd688 on 8.x-1.x
    Issue #3219111 by johnv: Clean code - office_hours.api.php Class usage
    

  • johnv committed 5fee118 on 8.x-1.x
    Issue #3219111: Clean code - updating some comments
    

  • johnv committed 92783ec6 on 8.x-1.x
    Issue #3219111: Clean code - OfficeHoursDateHelper
    

  • johnv committed 87c84ce5 on 8.x-1.x
    Issue #3219111: Clean code - indentation in schema.yml
    

  • johnv committed 7b14837c on 8.x-1.x
    Issue #3219111: Clean code - indentation in info.yml
    

  • johnv committed 45be87f7 on 8.x-1.x
    Issue #3219111: Clean code - office_hours.js
    

  • johnv committed 5bef74a7 on 8.x-1.x
    Issue #3219111: Clean code - multiple files
    

  • johnv committed f96ee0ce on 8.x-1.x
    Issue #3219111: Clean code - multiple files
    

  • johnv committed d165cbdb on 8.x-1.x
    Issue #3219111: Clean code -  multiple files
    

  • johnv committed 74e2db20 on 8.x-1.x
    Issue #3219111: Clean code - ofice_hours.js
    

  • johnv committed fa445328 on 8.x-1.x
    Issue #3219111 by johnv: Clean code - office_hours.js
    

  • johnv committed 7b85cb25 on 8.x-1.x
    Issue #3219111: 2 small changes
    

  • johnv committed cb3b407d on 8.x-1.x
    Issue #3219111: Clean code - PHPDoc in OfficeHoursWeekWidget
    

  • johnv committed cb24ba93 on 8.x-1.x
    Issue #3219111: Clean code - remove redundant code in FieldFormatters
    

  • johnv committed 6e330d4e on 8.x-1.x
    Issue #3219111: Clean code - use 'Exception day' nomenclature
    

  • johnv committed 2461af41 on 8.x-1.x
    Issue #3219111: Clean code - better issue handling
    

  • johnv committed e102e951 on 8.x-1.x
    Issue #3219111: Clean code - use 'Exception day' nomenclature
    

  • johnv committed 1b6ff3ef on 8.x-1.x
    Issue #3219111: Clean code - phpcs
    

  • johnv committed 16131924 on 8.x-1.x
    Issue #3219111: Clean code - introduce const DATE_STORAGE_FORMAT = 'Y-m-...

  • johnv committed 8bc48717 on 8.x-1.x
    Issue #3219111: Clean code - typo
    

  • johnv committed c7e6f353 on 8.x-1.x
    Issue #3219111: Clean code - update class annotation for field_types...

  • johnv committed fcddbc21 on 8.x-1.x
    Issue #3219111: Clean code - office_hours.js
    

  • johnv committed 1bb9816d on 8.x-1.x
    Issue #3219111: Clean code - office_hours.module file
    

  • johnv committed 07db0c7b on 8.x-1.x
    Issue #3219111: Clean code - WebformElement
    

  • johnv committed 62ec6b05 on 8.x-1.x
    Issue #3219111: Clean code - move code in theme.*.inc
    

  • johnv committed 06113845 on 8.x-1.x
    Issue #3219111: Clean code - rename addCacheMaxAge to addCacheData
    

  • johnv committed 71ffca9a on 8.x-1.x
    Issue #3219111: Clean code - fix typo
    

  • johnv committed 300faf68 on 8.x-1.x
    Issue #3219111: Clean code - rename addCacheMaxAge to addCacheData
    

  • johnv committed a7298906 on 8.x-1.x
    Issue #3219111: Clean code - indents
    

  • johnv committed 0123b828 on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed bab8c97d on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed e3e9ad61 on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed a175dcbd on 8.x-1.x
    Issue #3219111: Clean code - stylelint css files
    

  • johnv committed 5b91f9b6 on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed 99dc8656 on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed d5dac80a on 8.x-1.x
    Issue #3219111: Clean code - eslint js files
    

  • johnv committed 7c5ef3a2 on 8.x-1.x
    Issue #3219111: Clean code - hook_office_hours_current_time_alter()
    

  • johnv committed 2043f727 on 8.x-1.x
    Issue #3219111: Clean code - move (duplicate) getLabel() code from Item...

  • johnv committed 0d3f7ab9 on 8.x-1.x
    Issue #3219111: Clean code - move (duplicate) getLabel() code from Item...

  • johnv committed a946e5ff on 8.x-1.x
    Issue #3219111: Clean code - OfficeHoursDateHelper::hours()
    

  • johnv committed 4855656e on 8.x-1.x
    Issue #3219111: Move getExceptionDays() into itemList, since it is used...

  • johnv committed f000d4a6 on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 4a6cb9d8 on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 4ad90c93 on 8.x-1.x
    Issue #3219111: start using static::class
    

  • johnv committed 44d8b7ca on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 672f98b8 on 8.x-1.x
    Issue #3219111: use ternary operation in OfficeHoursFormatterBase
    

  • johnv committed 267ac85f on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed a49eb9bf on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed da6bb1db on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 139ae1ad on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed ee9cb501 on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 7d47b1fa on 8.x-1.x
    Issue #3219111: Introduce switch statement to determine item type
    

  • johnv committed 2e1d9a54 on 8.x-1.x
    Issue #3219111: clean code - phpcs
    

  • johnv committed 7ecdca3d on 8.x-1.x
    Issue #3219111: Remove usage of static OfficeHoursItem::formatLabel
    
hexabinaer’s picture

This issue is mentioned on the project page as a "hot topic".

Some help is appreciated for the following topics:
Add schema.org/openingHours microdata [1 issue]

Is this still the case? If so, please give a hint in the issue description, e. g. "test against schema.org".

We are thinking about using office_hours in OpenCulturas so there is a chance for help ;-)

johnv’s picture

I was surprised to find your message here. Thanks for your offer.
But apparently the topic is complete. If you select the 'closed issues' you see relevant work.

Indeed, please test and report back in a separate issue.
I do not really understand the difference between the following:
- https://schema.org/openingHours
- https://schema.org/OpeningHoursSpecification
and which one to use for this module.
Please check the setting in the formatter.

  • johnv committed 2e089b8d on 8.x-1.x
    Issue #3219111: Clean code - camelCase 'timeSlot' consistently
    

  • johnv committed 762d9c11 on 8.x-1.x
    Issue #3219111: Clean code - camelCase 'timeSlot' consistently
    

  • johnv committed addcf235 on 8.x-1.x
    Issue #3219111: Clean code - move code from .module file to...

  • johnv committed b2366636 on 8.x-1.x
    Issue #3219111: Clean code - consistent usage of capitals in Office...

  • johnv committed c361866b on 8.x-1.x
    Issue #3219111: Clean code - move code from .module file to...

  • johnv committed 1c6bcec5 on 8.x-1.x
    Issue #3219111: Clean code - add hook-update in .install file
    

  • johnv committed 0824d8dd on 8.x-1.x
    Issue #3219111: Clean code - phpcs
    

  • johnv committed b4117abe on 8.x-1.x
    Issue #3219111: Clean code - improve OfficeHoursItemInterface
    

  • johnv committed 11ccce0a on 8.x-1.x
    Issue #3219111: Clean code - src/OfficeHoursFormatterTrait.php
    

  • johnv committed a1ff633e on 8.x-1.x
    Issue #3219111: Better field description
    

  • johnv committed 7f9a5f1f on 8.x-1.x
    Issue #3219111: clean code OfficeHoursitem.php
    

  • johnv committed 02dff64f on 8.x-1.x
    Issue #3219111: clean code OfficeHoursSeason.php
    

  • johnv committed 88f13e5e on 8.x-1.x
    Issue #3219111: clean code OfficeHoursDatetime.php
    

  • johnv committed e272e922 on 8.x-1.x
    Issue #3219111: clean code - OfficeHoursDateHelper.php
    

  • johnv committed e1dbc8b5 on 8.x-1.x
    Issue #3219111: clean code - css/office_hours.css
    

  • johnv committed ab0358e0 on 8.x-1.x
    Issue #3219111: clean code - office_hours.install